Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer SQLite types locally #6381

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Apr 21, 2023

Pull Request Description

Closes #6208

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 21, 2023
@radeusgd radeusgd self-assigned this Apr 21, 2023
@radeusgd radeusgd marked this pull request as ready for review April 21, 2023 16:44
@radeusgd radeusgd requested a review from jdunkerley as a code owner April 21, 2023 16:44
@radeusgd radeusgd requested a review from GregoryTravis April 21, 2023 16:52
Base automatically changed from wip/radeusgd/aggregate-column-typechecks to develop April 24, 2023 08:55
@radeusgd radeusgd force-pushed the wip/radeusgd/sqlite-fix-type-inference-6208 branch from 6d2e56f to 9650bdf Compare April 24, 2023 10:03
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Apr 24, 2023
@mergify mergify bot merged commit f3873f9 into develop Apr 24, 2023
@mergify mergify bot deleted the wip/radeusgd/sqlite-fix-type-inference-6208 branch April 24, 2023 10:55
Procrat added a commit that referenced this pull request Apr 25, 2023
* develop:
  Turn null into UnexpectedExpression when Union type is incomplete (#6415)
  Ensure that IO.println does not fail if `to_text` returned a non-Text value. (#6223)
  Improve inlining of `<|` on (GraalVM EE) (#6384)
  Feat: update templates styles and feature (#6071)
  5127 Add Table.parse_to_columns to parse a single column to a set of columns. (#6383)
  URL handling (#6243)
  Exclude comparison operators from modifier logic (#6370)
  Better cleanup of project management test suite (#6392)
  Fix all eslint errors (#6267)
  Infer SQLite types locally (#6381)
  Vector Editor with List Editor and adding elements. (#6363)
  Add typechecks to Aggregate and Cross Tab (#6380)
  Forbid edits in read-only mode (#6342)
  Add Table.parse_text_to_table to convert Text to a Table. (#6294)
  Adding typechecks to Column Operations (#6298)
  Rollback cloud options groups (#6331)
  Project folder not renamed after project name change (#6369)
  Add `replace`, `trim` to Column. Better number parsing. (#6253)
  Read-only mode for controllers (#6259)
  Prevent default for all events, fixing multiple IDE bugs (#6364)
Akirathan pushed a commit that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite backend sometimes infers invalid types from the Metadata
3 participants