Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project folder not renamed after project name change #6369

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Project folder not renamed after project name change #6369

merged 4 commits into from
Apr 20, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Apr 20, 2023 •
edited
Loading

Pull Request Description

close #6254

Changelog:

  • fix: race when the actor system may be stopped before the shutdown hooks are executed
  • fix: project management spec
  • fix: recover from readLine failure during the shutdown

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 20, 2023
@4e6 4e6 self-assigned this Apr 20, 2023
@4e6 4e6 marked this pull request as ready for review April 20, 2023 15:52
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Apr 20, 2023
@mergify mergify bot merged commit 74c0718 into develop Apr 20, 2023
@mergify mergify bot deleted the wip/db/6254-project-folder-not-renamed-after-project-name-change-inside-enso branch April 20, 2023 16:57
@enso-bot enso-bot bot mentioned this pull request Apr 21, 2023
Closed
Procrat added a commit that referenced this pull request Apr 25, 2023
@Procrat
Merge branch 'develop' into wip/procrat/rename-project-with-space-5065
04b228f 
* develop:
  Turn null into UnexpectedExpression when Union type is incomplete (#6415)
  Ensure that IO.println does not fail if `to_text` returned a non-Text value. (#6223)
  Improve inlining of `<|` on (GraalVM EE) (#6384)
  Feat: update templates styles and feature (#6071)
  5127 Add Table.parse_to_columns to parse a single column to a set of columns. (#6383)
  URL handling (#6243)
  Exclude comparison operators from modifier logic (#6370)
  Better cleanup of project management test suite (#6392)
  Fix all eslint errors (#6267)
  Infer SQLite types locally (#6381)
  Vector Editor with List Editor and adding elements. (#6363)
  Add typechecks to Aggregate and Cross Tab (#6380)
  Forbid edits in read-only mode (#6342)
  Add Table.parse_text_to_table to convert Text to a Table. (#6294)
  Adding typechecks to Column Operations (#6298)
  Rollback cloud options groups (#6331)
  Project folder not renamed after project name change (#6369)
  Add `replace`, `trim` to Column. Better number parsing. (#6253)
  Read-only mode for controllers (#6259)
  Prevent default for all events, fixing multiple IDE bugs (#6364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project folder not renamed after project name change inside Enso
2 participants
@4e6 @hubertp