Rollback cloud options groups #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloBuchu
requested review from
indiv0,
somebody1234,
MichaelMauderer,
wdanilo and
kazcw
as code owners
PabloBuchu
added
the
CI: No changelog needed
somebody1234
approved these changes
Apr 18, 2023
wdanilo
requested changes
Apr 18, 2023
Comment on lines
46
to
47
| // FIXME[sb]: This is a temporary workaround and will be fixed | ||
| // when IDE support is properly integrated into the dashboard. |
There was a problem hiding this comment.
Every fixme should:
- Provide a clear semantic information of what it does. Here I see fixme and I don't understand what it really does and why it is considered a "hack".
- Provide link to an issue where it will be fixed.
There was a problem hiding this comment.
This was just a rollback but provided with proper format.
Comment on lines
7
to
9
| "newDashboard": { | ||
| "value": false, | ||
| "description": "Determines whether the dashboard (containing the directory listing) is enabled." |
There was a problem hiding this comment.
I don't think "new-dashboard" should be top-level option. We have there a group for things in the app that we are testing, like the new component browser. This option should land there.
There was a problem hiding this comment.
ok sounds good. Moving it to featurePreview group then
wdanilo
approved these changes
Apr 20, 2023
Procrat
added a commit
that referenced
this pull request
Apr 25, 2023
* develop: Turn null into UnexpectedExpression when Union type is incomplete (#6415) Ensure that IO.println does not fail if `to_text` returned a non-Text value. (#6223) Improve inlining of `<|` on (GraalVM EE) (#6384) Feat: update templates styles and feature (#6071) 5127 Add Table.parse_to_columns to parse a single column to a set of columns. (#6383) URL handling (#6243) Exclude comparison operators from modifier logic (#6370) Better cleanup of project management test suite (#6392) Fix all eslint errors (#6267) Infer SQLite types locally (#6381) Vector Editor with List Editor and adding elements. (#6363) Add typechecks to Aggregate and Cross Tab (#6380) Forbid edits in read-only mode (#6342) Add Table.parse_text_to_table to convert Text to a Table. (#6294) Adding typechecks to Column Operations (#6298) Rollback cloud options groups (#6331) Project folder not renamed after project name change (#6369) Add `replace`, `trim` to Column. Better number parsing. (#6253) Read-only mode for controllers (#6259) Prevent default for all events, fixing multiple IDE bugs (#6364)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR rollback newly created
cloudoptions groups. Instead in introduced new options flags-new-dashboardwhich indicated rendering new, react based ide dashboard instead of a rust one.It also fixes the regression when trying to enable authentication with old IDE.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.