Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .node-version for pinning Node.js version #6057

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Use .node-version for pinning Node.js version #6057

merged 1 commit into from
Mar 23, 2023

Conversation

Procrat
Copy link
Contributor

@Procrat Procrat commented Mar 23, 2023

Pull Request Description

Closes #6008: allowing Node.js to be used through Node version managers.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the Scala, Java, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Procrat Procrat added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 23, 2023
mwu-tow
mwu-tow suggested changes Mar 23, 2023
View reviewed changes
build/build/src/config.rs Show resolved Hide resolved
vitvakatu
vitvakatu approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@vitvakatu vitvakatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA passed

@Procrat Procrat added the CI: Ready to merge This PR is eligible for automatic merge label Mar 23, 2023
@mergify mergify bot merged commit 0bdf44c into develop Mar 23, 2023
@mergify mergify bot deleted the wip/procrat/pin-node-version-6008 branch March 23, 2023 12:00
Procrat added a commit that referenced this pull request Mar 27, 2023
@Procrat
Merge branch 'develop' into wip/procrat/node-action-bar-tooltips-5933
8b203e6 
* develop:
  Layout fixes (#6066)
  Use new Enso Hash Codes and Comparable (#6060)
  Search suggestions by static attribute (#6036)
  Use .node-version for pinning Node.js version (#6057)
  Fix code generation for suggestion preview (#6054)
  Implementation of EnsoGL predefined Rectangle shape. (#6033)
  Tidy up the public module level statics (#6032)
  Cursor aware Component Browser (#5770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@vitvakatu vitvakatu vitvakatu approved these changes

@mwu-tow mwu-tow mwu-tow approved these changes

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@wdanilo wdanilo Awaiting requested review from wdanilo

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Node.js to be used through Node version managers
4 participants
@Procrat @mwu-tow @farmaazon @vitvakatu