Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up the public module level statics #6032

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Mar 21, 2023

Pull Request Description

Tidies up a lot of PUBLIC module statics - marked some as PRIVATE, made some methods of types.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley linked an issue Mar 21, 2023 that may be closed by this pull request
2 tasks
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 21, 2023
@jdunkerley jdunkerley marked this pull request as ready for review March 21, 2023 17:12
@jdunkerley jdunkerley force-pushed the wip/jd/6024-no-error-and-no-visualization-when-using-standardbasedatajsonparse branch from 0946c29 to 43688e2 Compare March 21, 2023 17:13
@enso-bot
Copy link

enso-bot bot commented Mar 21, 2023

James Dunkerley reports a new STANDUP for today (2023-03-21):

Progress: Scanned all the static methods and PRIVATEd those that should be. Fix a defect in table.js for JS objects. Sorted the backlog with Sylwia. PR work with Greg on Regex replace. Started looking at using hash codes from Enso. It should be finished by 2023-03-22.

Next Day: Next day I will be working on the #5046 task. Finish hash code use.

@jdunkerley jdunkerley force-pushed the wip/jd/6024-no-error-and-no-visualization-when-using-standardbasedatajsonparse branch from 43688e2 to 78c5d77 Compare March 22, 2023 08:36
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the JS file.

Comment on lines 111 to +116
random_gen = Random.new
case random_gen of
Polyglot.Polyglot -> Nothing
Polyglot -> Nothing
_ -> Test.fail "Expected a polyglot object to match."
case Polyglot.Polyglot of
Polyglot.Polyglot -> Nothing
case Polyglot of
Polyglot -> Nothing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That indeed seems to look better.

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

I'm especially glad of moving some of the internals to an Internal module.

@jdunkerley jdunkerley force-pushed the wip/jd/6024-no-error-and-no-visualization-when-using-standardbasedatajsonparse branch from 6bd5c71 to 920abd7 Compare March 22, 2023 10:52
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 22, 2023
@mergify mergify bot merged commit dd009fd into develop Mar 22, 2023
@mergify mergify bot deleted the wip/jd/6024-no-error-and-no-visualization-when-using-standardbasedatajsonparse branch March 22, 2023 18:02
Procrat added a commit that referenced this pull request Mar 27, 2023
* develop:
  Layout fixes (#6066)
  Use new Enso Hash Codes and Comparable (#6060)
  Search suggestions by static attribute (#6036)
  Use .node-version for pinning Node.js version (#6057)
  Fix code generation for suggestion preview (#6054)
  Implementation of EnsoGL predefined Rectangle shape. (#6033)
  Tidy up the public module level statics (#6032)
  Cursor aware Component Browser (#5770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error and no visualization when using Standard.Base.Data.Json.parse
5 participants