-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up the public module level statics #6032
Tidy up the public module level statics #6032
Conversation
0946c29
to
43688e2
Compare
James Dunkerley reports a new STANDUP for today (2023-03-21): Progress: Scanned all the static methods and PRIVATEd those that should be. Fix a defect in table.js for JS objects. Sorted the backlog with Sylwia. PR work with Greg on Regex replace. Started looking at using hash codes from Enso. It should be finished by 2023-03-22. Next Day: Next day I will be working on the #5046 task. Finish hash code use. |
43688e2
to
78c5d77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the JS file.
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Aggregate_Column_Helper.enso
Outdated
Show resolved
Hide resolved
random_gen = Random.new | ||
case random_gen of | ||
Polyglot.Polyglot -> Nothing | ||
Polyglot -> Nothing | ||
_ -> Test.fail "Expected a polyglot object to match." | ||
case Polyglot.Polyglot of | ||
Polyglot.Polyglot -> Nothing | ||
case Polyglot of | ||
Polyglot -> Nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That indeed seems to look better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good.
I'm especially glad of moving some of the internals to an Internal
module.
Fix issue with Object array in table viz.
Co-authored-by: Radosław Waśko <[email protected]>
…te_Column_Helper.enso Co-authored-by: Radosław Waśko <[email protected]>
6bd5c71
to
920abd7
Compare
…-when-using-standardbasedatajsonparse
…-when-using-standardbasedatajsonparse
* develop: Layout fixes (#6066) Use new Enso Hash Codes and Comparable (#6060) Search suggestions by static attribute (#6036) Use .node-version for pinning Node.js version (#6057) Fix code generation for suggestion preview (#6054) Implementation of EnsoGL predefined Rectangle shape. (#6033) Tidy up the public module level statics (#6032) Cursor aware Component Browser (#5770)
Pull Request Description
Tidies up a lot of PUBLIC module statics - marked some as PRIVATE, made some methods of types.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.