Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code generation for suggestion preview #6054

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix code generation for suggestion preview #6054

merged 2 commits into from
Mar 23, 2023

Conversation

vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Mar 22, 2023 •
edited
Loading

Pull Request Description

Fix a stupid typo introduced in #5770. It affected the code generated by CB while previewing suggestions.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu self-assigned this Mar 22, 2023
@vitvakatu vitvakatu added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Mar 22, 2023
@mergify mergify bot merged commit de008eb into develop Mar 23, 2023
@mergify mergify bot deleted the wip/vitvakatu/fix-cb-preview branch March 23, 2023 06:34
Procrat added a commit that referenced this pull request Mar 27, 2023
@Procrat
Merge branch 'develop' into wip/procrat/node-action-bar-tooltips-5933
8b203e6 
* develop:
  Layout fixes (#6066)
  Use new Enso Hash Codes and Comparable (#6060)
  Search suggestions by static attribute (#6036)
  Use .node-version for pinning Node.js version (#6057)
  Fix code generation for suggestion preview (#6054)
  Implementation of EnsoGL predefined Rectangle shape. (#6033)
  Tidy up the public module level statics (#6032)
  Cursor aware Component Browser (#5770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdanilo wdanilo wdanilo approved these changes

@kazcw kazcw kazcw approved these changes

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@mwu-tow mwu-tow Awaiting requested review from mwu-tow

Assignees

@vitvakatu vitvakatu

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitvakatu @kazcw @wdanilo