Layout fixes #6066
Merged
Layout fixes #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created as draft, as I still need to test if changes does not break something in IDE. Besides, it's ready for review. |
farmaazon
added
the
CI: No changelog needed
farmaazon
force-pushed
the
wip/farmaazon/layout-fixes
branch
from
5a314d6 to
8dc91f0
Compare
farmaazon
force-pushed
the
wip/farmaazon/layout-fixes
branch
from
8dc91f0 to
289714d
Compare
wdanilo
approved these changes
Mar 24, 2023
Comment on lines
3070
to
3073
| if self.dirty.transformation.check() | ||
| || self.dirty.modified_children.check_all() | ||
| || self.dirty.removed_children.check_all() => | ||
| 0.0, |
There was a problem hiding this comment.
Please check if it is possible to minimize the amount of checks, as we agreed via phone.
Comment on lines
3081
to
3084
| if self.dirty.transformation.check() | ||
| || self.dirty.modified_children.check_all() | ||
| || self.dirty.removed_children.check_all() | ||
| { |
There was a problem hiding this comment.
could you please refactor that to one helper fn?
wdanilo
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
@farmaazon and @Frizi amazing job with debugging and fixing it! I'm sorry I did not spot these issues when I was developing the code.
|
Merged, as we need it to develop the codebase, and the CI problems seem unrelated. |
Procrat
added a commit
that referenced
this pull request
Mar 27, 2023
* develop: Layout fixes (#6066) Use new Enso Hash Codes and Comparable (#6060) Search suggestions by static attribute (#6036) Use .node-version for pinning Node.js version (#6057) Fix code generation for suggestion preview (#6054) Implementation of EnsoGL predefined Rectangle shape. (#6033) Tidy up the public module level statics (#6032) Cursor aware Component Browser (#5770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR contains fixes for several bugs found by me and @Frizi during development of our current tasks. Created unit tests for each case (and many more).
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.