Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error and no visualization when using Standard.Base.Data.Json.parse #6024

Closed
2 tasks
wdanilo opened this issue Mar 21, 2023 · 4 comments · Fixed by #6032
Closed
2 tasks

No error and no visualization when using Standard.Base.Data.Json.parse #6024

wdanilo opened this issue Mar 21, 2023 · 4 comments · Fixed by #6032
Assignees
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented

Comments

@wdanilo
Copy link
Member

wdanilo commented Mar 21, 2023

Discord username

No response

What type of issue is this?

Permanent – Ocurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

I'm trying to create such a graph. There is no error nor visualization:

image

Expected behaviour

Either error or visualization. dead sd and asks fast and asd

How we can reproduce it?

Create the graph from screenshot.

Screenshots or screencasts

No response

Enso Version

newest

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response

@wdanilo wdanilo added --bug Type: bug triage labels Mar 21, 2023
@jdunkerley jdunkerley self-assigned this Mar 21, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone Mar 21, 2023
@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented and removed triage labels Mar 21, 2023
@jdunkerley
Copy link
Member

json_parse function is an internal one not marked by PRIVATE (will fix).
The JSON format is incorrect and does error. Once fixed and using Json.parse works as expected.

Image

Will tag the private functions.

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 21, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 21, 2023
@jdunkerley jdunkerley linked a pull request Mar 21, 2023 that will close this issue
5 tasks
@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 21, 2023
@wdanilo
Copy link
Member Author

wdanilo commented Mar 22, 2023

Great, however, I still don't understand the behavior I got there. How a function could be evaluated not producing visualization nor error? I understand it was internal function, but still, something should be visible, right?

@jdunkerley
Copy link
Member

This is a JavaScript function.

As the JSON text was invalid the function will have thrown an error.

I'm guessing the engine/language server swallowed it - which shouldn't be the case. I will check and see if there is a panic being lost and raise with the engine team if so.

@jdunkerley
Copy link
Member

Having resolved the import issue so we don't get the module and type clash it is now returning the error cleanly.
image

Once the code has been merged this should be resolved.

@mergify mergify bot closed this as completed in #6032 Mar 22, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants