Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Node.js to be used through Node version managers #6008

Closed
Procrat opened this issue Mar 20, 2023 · 3 comments · Fixed by #6057
Closed

Allow Node.js to be used through Node version managers #6008

Procrat opened this issue Mar 20, 2023 · 3 comments · Fixed by #6057
Assignees
Labels
-build-script Category: build script d-easy Difficulty: little prior knowledge required good first issue p-low Low priority s-help-wanted Status: help wanted with the task x-new-feature Type: new feature request

Comments

@Procrat
Copy link
Contributor

Procrat commented Mar 20, 2023

Discord username

Stijn#6455

How important is this feature to you?

0 – Not too important

Describe the idea you'd like to see implemented.

If we put a .node-version in the root of the repo, Node.js version managers like fnm, nvm, nvs, n, nave, nodeenv, nodist, ... automatically select the right Node version. At the moment, it either needs to be set manually or the system-installed version is used.

I can make a PR with it, but the version number would be duplicated in build-config.yaml, unless the build script were to look for the version number.

Is your feature request related to a problem?

The system-installed Node version is rarely the exact one pinned by Enso. This results in one more hurdle to cross for new people to build Enso for the first time.

Screenshots, screencasts, mockups.

No response

Would you be willing to help us implement this feature?

Yes

@Procrat Procrat added d-easy Difficulty: little prior knowledge required -build-script Category: build script triage labels Mar 20, 2023
@vitvakatu vitvakatu added s-help-wanted Status: help wanted with the task x-new-feature Type: new feature request p-low Low priority good first issue and removed triage labels Mar 20, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Mar 20, 2023
@wdanilo
Copy link
Member

wdanilo commented Mar 21, 2023

I like it. Didn't know that you can use this file to hint these tools with the version. Please create PR with it. Also, take a look at the build script, if you'd be able to fix it in 15-30 mins, include it in your PR. If not, add a note there that it needs to be fixed :)

@mwu-tow
Copy link
Contributor

mwu-tow commented Mar 21, 2023

It's no problem for build script to take the version from the file. We do a similar for retrieving the GraalVM version from build.sbt.
If anyone needs some help with this, please ping me.

@Procrat By the way if there are node version managers that:

  • work across Windows, Linux, and macOS;
  • do not not require root privileges.

Then it might be worth updating documentation and guiding users to it — the fewer platform-specific setup instructions and more out-of-the-box just working, the better.

Procrat added a commit that referenced this issue Mar 23, 2023
Procrat added a commit that referenced this issue Mar 23, 2023
@Procrat Procrat moved this from 📤 Backlog to 🌟 Q/A review in Issues Board Mar 23, 2023
@Procrat Procrat assigned Procrat and unassigned mwu-tow Mar 23, 2023
@mergify mergify bot closed this as completed in #6057 Mar 23, 2023
mergify bot pushed a commit that referenced this issue Mar 23, 2023
Closes #6008: allowing Node.js to be used through Node version managers.
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Mar 23, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 23, 2023

Stijn Seghers reports a new STANDUP for today (2023-03-23):

Progress: Made our build setup use .node-version so Node version managers can be used It should be finished by 2023-03-23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-build-script Category: build script d-easy Difficulty: little prior knowledge required good first issue p-low Low priority s-help-wanted Status: help wanted with the task x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants