[Synthetics] Adjust content #156029
Merged
[Synthetics] Adjust content #156029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dominiqueclarke
commented
Apr 27, 2023
.../synthetics/public/apps/synthetics/components/settings/private_locations/delete_location.tsx
Outdated
Show resolved
Hide resolved
…ttings/private_locations/delete_location.tsx
…om/dominiqueclarke/kibana into fix/synthetics-content-adjustments
…content-adjustments
…om/dominiqueclarke/kibana into fix/synthetics-content-adjustments
dominiqueclarke
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
florent-leborgne
approved these changes
May 2, 2023
...ns/synthetics/public/apps/synthetics/components/monitor_add_edit/steps/read_only_callout.tsx
Outdated
Show resolved
Hide resolved
| { | ||
| defaultMessage: | ||
| 'Synthetics App is currently disabled. Synthetics App allows you to run lightweight and real-browser monitors from hosted testing locations around the world. To enable Synthetics App, please contact an administrator.', | ||
| defaultMessage: 'Only administrators can enable this feature.', |
There was a problem hiding this comment.
Could we also show the "Enable Synthetics" button, but in a disabled state? Just so that this sentence makes more sense. Up to you, just my 2 cents here :)
There was a problem hiding this comment.
There actually isn't an Enable Synthetics button at all any more, now we have an automatic workflow.
Do you think having a dummy button here would still be helpful?
There was a problem hiding this comment.
I think that having the button makes it clearer that an admin navigating to this page would do the trick, so yes.
If a user with no admin right comes here, they'll see "Only admins can enable the feature", but without the button it doesn't hint on where admins need to go when the user goes to ask them.
Not sure if I'm clear with my explanations, maybe that's not so relevant :) Maybe an alternative to the disabled button would be to explain how the admin can enable the feature: "Only administrators can enable this feature by navigating to this page." ? But that sounds a lot more wordy than the disabled button.
There was a problem hiding this comment.
@paulb-elastic Any thoughts here?
There was a problem hiding this comment.
Might be too late, so feel free to ignore my comment. I guess the only thing about seeing a disabled button is that the admin might wonder how to the page where the button is, but there isn't one (as it's done automatically).
I'm not too worried either way - if it's already been added, then that's ok, if not, then I'm ok going without it.
| @@ -93,7 +93,7 @@ export const AlertDefaultsForm = () => { | |||
| description={ | |||
| <FormattedMessage | |||
| id="xpack.synthetics.settings.defaultConnectors.description" | |||
| defaultMessage="Selector one or more connectors to be used for alerts. These settings will be applied to all synthetics based alerts." | |||
| defaultMessage="Select one or more connectors to be used for alerts. These settings apply to all synthetics-based alerts." | |||
.../synthetics/public/apps/synthetics/components/settings/private_locations/delete_location.tsx
Outdated
Show resolved
Hide resolved
.../synthetics/public/apps/synthetics/components/settings/private_locations/delete_location.tsx
Outdated
Show resolved
Hide resolved
...tics/public/apps/synthetics/components/settings/private_locations/view_location_monitors.tsx
Outdated
Show resolved
Hide resolved
...tics/public/apps/synthetics/components/settings/private_locations/view_location_monitors.tsx
Outdated
Show resolved
Hide resolved
…nitor_add_edit/steps/read_only_callout.tsx Co-authored-by: florent-leborgne <[email protected]>
…ttings/private_locations/delete_location.tsx Co-authored-by: florent-leborgne <[email protected]>
…ttings/private_locations/delete_location.tsx Co-authored-by: florent-leborgne <[email protected]>
…ttings/private_locations/view_location_monitors.tsx Co-authored-by: florent-leborgne <[email protected]>
…ttings/private_locations/view_location_monitors.tsx Co-authored-by: florent-leborgne <[email protected]>
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
justinkambic
approved these changes
May 2, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2023
## Summary Resolves elastic#155936 Relates to elastic#152915 Resolves elastic#150944 Resolves elastic#156166 Copy fixes: - Alerting config: Address Typo (elastic#152915 (comment)) - Alerting config: Address success toast wording - Getting started ("Create your first monitor") locations: Repeated text between placeholder and hint text. To address this, I changed the helptext to give more detail - Private locations -> "Monitors" column: replaced `Running` with `configured` - Overview page: Search bar placeholder: `url` is now uppercase `URL` - Monitor status alert - Updates text for viewer user to be consistent with other tooltips - Run once errors - Remove extra error toast - Run once errors - Remove excess phrase from error - Sync errors - Made content more user friendly - Synthetics App - replace references to Monitor Management with Synthetics App - Enable/disable - clarify when actions apply to all monitors - Project monitors - add reference to enabling/disabling alerting on project monitor page - Enablement - Adjust content for less privileged users Some screenshots of the fixes are below. These are not exhaustive <img width="1417" alt="Screen Shot 2023-04-25 at 12 12 38 PM" src="https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png"> <img width="772" alt="Screen Shot 2023-04-25 at 12 12 31 PM" src="https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png"> <img width="909" alt="Screen Shot 2023-04-25 at 12 12 10 PM" src="https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png"> <img width="1414" alt="Screen Shot 2023-04-25 at 11 59 57 AM" src="https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png"> <img width="623" alt="Screen Shot 2023-04-25 at 11 57 53 AM" src="https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png"> <img width="735" alt="Screen Shot 2023-04-27 at 4 16 17 PM" src="https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png"> <img width="1240" alt="Screen Shot 2023-04-28 at 2 09 29 PM" src="https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png"> <img width="602" alt="Screen Shot 2023-04-28 at 11 12 49 AM" src="https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png"> <img width="552" alt="Screen Shot 2023-04-28 at 11 12 25 AM" src="https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png"> <img width="1448" alt="Screen Shot 2023-04-28 at 2 56 58 PM" src="https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png"> --------- Co-authored-by: florent-leborgne <[email protected]> Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 589ea3a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Adjust content (#156029)](#156029) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T21:23:04Z","message":"[Synthetics] Adjust content (#156029)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/155936\r\nRelates to https://github.com/elastic/kibana/issues/152915\r\nResolves https://github.com/elastic/kibana/issues/150944\r\nResolves https://github.com/elastic/kibana/issues/156166\r\n\r\nCopy fixes:\r\n\r\n- Alerting config: Address Typo\r\n(https://github.com/elastic/kibana/issues/152915#issuecomment-1516614675)\r\n- Alerting config: Address success toast wording\r\n- Getting started (\"Create your first monitor\") locations: Repeated text\r\nbetween placeholder and hint text. To address this, I changed the\r\nhelptext to give more detail\r\n- Private locations -> \"Monitors\" column: replaced `Running` with\r\n`configured`\r\n- Overview page: Search bar placeholder: `url` is now uppercase `URL`\r\n- Monitor status alert - Updates text for viewer user to be consistent\r\nwith other tooltips\r\n- Run once errors - Remove extra error toast \r\n- Run once errors - Remove excess phrase from error\r\n- Sync errors - Made content more user friendly\r\n- Synthetics App - replace references to Monitor Management with\r\nSynthetics App\r\n- Enable/disable - clarify when actions apply to all monitors\r\n- Project monitors - add reference to enabling/disabling alerting on\r\nproject monitor page\r\n- Enablement - Adjust content for less privileged users\r\n\r\nSome screenshots of the fixes are below. These are not exhaustive\r\n<img width=\"1417\" alt=\"Screen Shot 2023-04-25 at 12 12 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img width=\"772\" alt=\"Screen Shot 2023-04-25 at 12 12 31 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img width=\"909\" alt=\"Screen Shot 2023-04-25 at 12 12 10 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img width=\"1414\" alt=\"Screen Shot 2023-04-25 at 11 59 57 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img width=\"623\" alt=\"Screen Shot 2023-04-25 at 11 57 53 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img width=\"735\" alt=\"Screen Shot 2023-04-27 at 4 16 17 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img width=\"1240\" alt=\"Screen Shot 2023-04-28 at 2 09 29 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img width=\"602\" alt=\"Screen Shot 2023-04-28 at 11 12 49 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img width=\"552\" alt=\"Screen Shot 2023-04-28 at 11 12 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img width=\"1448\" alt=\"Screen Shot 2023-04-28 at 2 56 58 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <[email protected]>\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"589ea3affc6c64ef69c81bc01da767388b246dc9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","Team:Fleet","v8.8.0","v8.9.0"],"number":156029,"url":"https://github.com/elastic/kibana/pull/156029","mergeCommit":{"message":"[Synthetics] Adjust content (#156029)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/155936\r\nRelates to https://github.com/elastic/kibana/issues/152915\r\nResolves https://github.com/elastic/kibana/issues/150944\r\nResolves https://github.com/elastic/kibana/issues/156166\r\n\r\nCopy fixes:\r\n\r\n- Alerting config: Address Typo\r\n(https://github.com/elastic/kibana/issues/152915#issuecomment-1516614675)\r\n- Alerting config: Address success toast wording\r\n- Getting started (\"Create your first monitor\") locations: Repeated text\r\nbetween placeholder and hint text. To address this, I changed the\r\nhelptext to give more detail\r\n- Private locations -> \"Monitors\" column: replaced `Running` with\r\n`configured`\r\n- Overview page: Search bar placeholder: `url` is now uppercase `URL`\r\n- Monitor status alert - Updates text for viewer user to be consistent\r\nwith other tooltips\r\n- Run once errors - Remove extra error toast \r\n- Run once errors - Remove excess phrase from error\r\n- Sync errors - Made content more user friendly\r\n- Synthetics App - replace references to Monitor Management with\r\nSynthetics App\r\n- Enable/disable - clarify when actions apply to all monitors\r\n- Project monitors - add reference to enabling/disabling alerting on\r\nproject monitor page\r\n- Enablement - Adjust content for less privileged users\r\n\r\nSome screenshots of the fixes are below. These are not exhaustive\r\n<img width=\"1417\" alt=\"Screen Shot 2023-04-25 at 12 12 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img width=\"772\" alt=\"Screen Shot 2023-04-25 at 12 12 31 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img width=\"909\" alt=\"Screen Shot 2023-04-25 at 12 12 10 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img width=\"1414\" alt=\"Screen Shot 2023-04-25 at 11 59 57 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img width=\"623\" alt=\"Screen Shot 2023-04-25 at 11 57 53 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img width=\"735\" alt=\"Screen Shot 2023-04-27 at 4 16 17 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img width=\"1240\" alt=\"Screen Shot 2023-04-28 at 2 09 29 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img width=\"602\" alt=\"Screen Shot 2023-04-28 at 11 12 49 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img width=\"552\" alt=\"Screen Shot 2023-04-28 at 11 12 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img width=\"1448\" alt=\"Screen Shot 2023-04-28 at 2 56 58 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <[email protected]>\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"589ea3affc6c64ef69c81bc01da767388b246dc9"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156029","number":156029,"mergeCommit":{"message":"[Synthetics] Adjust content (#156029)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/155936\r\nRelates to https://github.com/elastic/kibana/issues/152915\r\nResolves https://github.com/elastic/kibana/issues/150944\r\nResolves https://github.com/elastic/kibana/issues/156166\r\n\r\nCopy fixes:\r\n\r\n- Alerting config: Address Typo\r\n(https://github.com/elastic/kibana/issues/152915#issuecomment-1516614675)\r\n- Alerting config: Address success toast wording\r\n- Getting started (\"Create your first monitor\") locations: Repeated text\r\nbetween placeholder and hint text. To address this, I changed the\r\nhelptext to give more detail\r\n- Private locations -> \"Monitors\" column: replaced `Running` with\r\n`configured`\r\n- Overview page: Search bar placeholder: `url` is now uppercase `URL`\r\n- Monitor status alert - Updates text for viewer user to be consistent\r\nwith other tooltips\r\n- Run once errors - Remove extra error toast \r\n- Run once errors - Remove excess phrase from error\r\n- Sync errors - Made content more user friendly\r\n- Synthetics App - replace references to Monitor Management with\r\nSynthetics App\r\n- Enable/disable - clarify when actions apply to all monitors\r\n- Project monitors - add reference to enabling/disabling alerting on\r\nproject monitor page\r\n- Enablement - Adjust content for less privileged users\r\n\r\nSome screenshots of the fixes are below. These are not exhaustive\r\n<img width=\"1417\" alt=\"Screen Shot 2023-04-25 at 12 12 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img width=\"772\" alt=\"Screen Shot 2023-04-25 at 12 12 31 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img width=\"909\" alt=\"Screen Shot 2023-04-25 at 12 12 10 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img width=\"1414\" alt=\"Screen Shot 2023-04-25 at 11 59 57 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img width=\"623\" alt=\"Screen Shot 2023-04-25 at 11 57 53 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img width=\"735\" alt=\"Screen Shot 2023-04-27 at 4 16 17 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img width=\"1240\" alt=\"Screen Shot 2023-04-28 at 2 09 29 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img width=\"602\" alt=\"Screen Shot 2023-04-28 at 11 12 49 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img width=\"552\" alt=\"Screen Shot 2023-04-28 at 11 12 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img width=\"1448\" alt=\"Screen Shot 2023-04-28 at 2 56 58 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <[email protected]>\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"589ea3affc6c64ef69c81bc01da767388b246dc9"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <[email protected]>
![https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by](https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #155936
Relates to #152915
Resolves #150944
Resolves #156166
Resolves #156028
Copy fixes:
Runningwithconfiguredurlis now uppercaseURLSome screenshots of the fixes are below. These are not exhaustive
