-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Adjust content #156029
Merged
dominiqueclarke
merged 27 commits into
elastic:main
from
dominiqueclarke:fix/synthetics-content-adjustments
May 2, 2023
Merged
[Synthetics] Adjust content #156029
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1ddb593
adjust content
dominiqueclarke 59afd3a
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
dominiqueclarke e1932b6
adjust content
dominiqueclarke 3219781
Merge branch 'fix/synthetics-content-adjustments' of https://github.c…
dominiqueclarke b52d45f
Merge branch 'main' into fix/synthetics-content-adjustments
dominiqueclarke 914dc4e
Merge branch 'main' into fix/synthetics-content-adjustments
dominiqueclarke 1565df8
adjust tooltip content
dominiqueclarke 67c2792
Merge branch 'main' of github.com:elastic/kibana into fix/synthetics-…
dominiqueclarke fe1e4b4
adjust error content for run once
dominiqueclarke 7bcda42
Merge branch 'fix/synthetics-content-adjustments' of https://github.c…
dominiqueclarke 30ba191
remove unused translations
dominiqueclarke 3ecd1f2
replace references to monitor management with synthetics app
dominiqueclarke 4416340
adjust content
dominiqueclarke 7a2e857
clarify actions that are applied to all locations
dominiqueclarke b2460d3
remove unused translations
dominiqueclarke 950e39e
adjust monitor sync error content
dominiqueclarke a75c318
update tests
dominiqueclarke 82be10e
adjust read only callout text
dominiqueclarke 6640fe9
adjust enablement message for less privileged users
dominiqueclarke a907f9c
remove unused translations
dominiqueclarke 590804b
Merge branch 'main' into fix/synthetics-content-adjustments
dominiqueclarke 8c72f1b
Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…
dominiqueclarke f1810ee
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
dominiqueclarke 6d29e64
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
dominiqueclarke 8c40515
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
dominiqueclarke 7d75707
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
dominiqueclarke d0a155a
Merge branch 'main' into fix/synthetics-content-adjustments
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,7 +93,7 @@ export const AlertDefaultsForm = () => { | |
description={ | ||
<FormattedMessage | ||
id="xpack.synthetics.settings.defaultConnectors.description" | ||
defaultMessage="Selector one or more connectors to be used for alerts. These settings will be applied to all synthetics based alerts." | ||
defaultMessage="Select one or more connectors to be used for alerts. These settings apply to all synthetics-based alerts." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 👍 👍 |
||
/> | ||
} | ||
> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also show the "Enable Synthetics" button, but in a disabled state? Just so that this sentence makes more sense. Up to you, just my 2 cents here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There actually isn't an Enable Synthetics button at all any more, now we have an automatic workflow.
Do you think having a dummy button here would still be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that having the button makes it clearer that an admin navigating to this page would do the trick, so yes.
If a user with no admin right comes here, they'll see "Only admins can enable the feature", but without the button it doesn't hint on where admins need to go when the user goes to ask them.
Not sure if I'm clear with my explanations, maybe that's not so relevant :) Maybe an alternative to the disabled button would be to explain how the admin can enable the feature: "Only administrators can enable this feature by navigating to this page." ? But that sounds a lot more wordy than the disabled button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulb-elastic Any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be too late, so feel free to ignore my comment. I guess the only thing about seeing a disabled button is that the admin might wonder how to the page where the button is, but there isn't one (as it's done automatically).
I'm not too worried either way - if it's already been added, then that's ok, if not, then I'm ok going without it.