Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.8] [Synthetics] Adjust content (#156029) #156451

Merged
merged 1 commit into from
May 2, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

## Summary

Resolves elastic#155936
Relates to elastic#152915
Resolves elastic#150944
Resolves elastic#156166

Copy fixes:

- Alerting config: Address Typo
(elastic#152915 (comment))
- Alerting config: Address success toast wording
- Getting started ("Create your first monitor") locations: Repeated text
between placeholder and hint text. To address this, I changed the
helptext to give more detail
- Private locations -> "Monitors" column: replaced `Running` with
`configured`
- Overview page: Search bar placeholder: `url` is now uppercase `URL`
- Monitor status alert - Updates text for viewer user to be consistent
with other tooltips
- Run once errors - Remove extra error toast
- Run once errors - Remove excess phrase from error
- Sync errors - Made content more user friendly
- Synthetics App - replace references to Monitor Management with
Synthetics App
- Enable/disable - clarify when actions apply to all monitors
- Project monitors - add reference to enabling/disabling alerting on
project monitor page
- Enablement - Adjust content for less privileged users

Some screenshots of the fixes are below. These are not exhaustive
<img width="1417" alt="Screen Shot 2023-04-25 at 12 12 38 PM"
src="https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png">
<img width="772" alt="Screen Shot 2023-04-25 at 12 12 31 PM"
src="https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png">
<img width="909" alt="Screen Shot 2023-04-25 at 12 12 10 PM"
src="https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png">
<img width="1414" alt="Screen Shot 2023-04-25 at 11 59 57 AM"
src="https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png">
<img width="623" alt="Screen Shot 2023-04-25 at 11 57 53 AM"
src="https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png">
<img width="735" alt="Screen Shot 2023-04-27 at 4 16 17 PM"
src="https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png">
<img width="1240" alt="Screen Shot 2023-04-28 at 2 09 29 PM"
src="https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png">
<img width="602" alt="Screen Shot 2023-04-28 at 11 12 49 AM"
src="https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png">
<img width="552" alt="Screen Shot 2023-04-28 at 11 12 25 AM"
src="https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png">
<img width="1448" alt="Screen Shot 2023-04-28 at 2 56 58 PM"
src="https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png">

---------

Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 589ea3a)
@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels May 2, 2023
@kibanamachine kibanamachine enabled auto-merge (squash) May 2, 2023 21:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB -1.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dominiqueclarke

@kibanamachine kibanamachine merged commit 372d38f into elastic:8.8 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants