Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Adjust content #156029
[Synthetics] Adjust content #156029
Changes from 21 commits
1ddb593
59afd3a
e1932b6
3219781
b52d45f
914dc4e
1565df8
67c2792
fe1e4b4
7bcda42
30ba191
3ecd1f2
4416340
7a2e857
b2460d3
950e39e
a75c318
82be10e
6640fe9
a907f9c
590804b
8c72f1b
f1810ee
6d29e64
8c40515
7d75707
d0a155a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also show the "Enable Synthetics" button, but in a disabled state? Just so that this sentence makes more sense. Up to you, just my 2 cents here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There actually isn't an Enable Synthetics button at all any more, now we have an automatic workflow.
Do you think having a dummy button here would still be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that having the button makes it clearer that an admin navigating to this page would do the trick, so yes.
If a user with no admin right comes here, they'll see "Only admins can enable the feature", but without the button it doesn't hint on where admins need to go when the user goes to ask them.
Not sure if I'm clear with my explanations, maybe that's not so relevant :) Maybe an alternative to the disabled button would be to explain how the admin can enable the feature: "Only administrators can enable this feature by navigating to this page." ? But that sounds a lot more wordy than the disabled button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulb-elastic Any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be too late, so feel free to ignore my comment. I guess the only thing about seeing a disabled button is that the admin might wonder how to the page where the button is, but there isn't one (as it's done automatically).
I'm not too worried either way - if it's already been added, then that's ok, if not, then I'm ok going without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍