[Saved Objects] Import SO types from server rather than common to avoid deprecation
#149289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
chore
Team:Core
jloleysens
force-pushed
the
import-so-types-from-server
branch
from
725af0e to
cd0806d
Compare
…objects-api-server
|
Pinging @elastic/kibana-core (Team:Core) |
botelastic
bot
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
approved these changes
Jan 23, 2023
pgayvallet
approved these changes
Jan 23, 2023
| @@ -7,7 +7,7 @@ | |||
| */ | |||
|
|
|||
| import { isNotFoundFromUnsupportedServer } from '@kbn/core-elasticsearch-server-internal'; | |||
| import type { SavedObject } from '@kbn/core-saved-objects-common'; | |||
There was a problem hiding this comment.
Yeah... It kinda awkward having to do this to avoid the deprecation, given both types are supposed to be the same, but if that's the direction we're willing to take, I guess it's fine.
stratoula
approved these changes
Jan 23, 2023
jeramysoucy
approved these changes
Jan 23, 2023
* main: (54 commits) [APM] Allow calling `createInternalESClient` without `context` (elastic#149320) [Synthetics] Errors list active state (elastic#149387) [FTRs] Execution Context: fix no data flakiness (elastic#149406) [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530) Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521) [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883) [ML] Remove job_type from job definitions in modules (elastic#149247) [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224) [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142) [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945) [Lens] Enable previous time shift when using a date histogram (elastic#149126) [Synthetics] Object types panel and thresholds (elastic#149099) [Fleet] added back batch exec for update tags (elastic#148618) 148790 - Fix scroll style for setup guide flyout (elastic#149242) Fix a11y issue with dev tool tabs (elastic#149349) [APM] Fix mobile indices (elastic#149230) [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943) renderCustomActionsRow with named params instead of args (elastic#149304) [ML] Adding ML execution context to es requests (elastic#148746) [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261) ...
|
@jloleysens FYI I ran into some circular references between the |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @jloleysens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging #148979 there are a number of imports that can be fixed immediately to address our new deprecation notice.
To Core reviewers
The package
core-saved-objects-serveris using types fromcore-saved-objects-api-serverwhich creates a circular dependency when usingSavedObjecttype from it's new home incore-saved-object-server:core-saved-objects-server->core-saved-objects-api-server->core-saved-objects-serverOne solution is that we can create a new package
packages/core/saved-objects/core-saved-objects-server-sharedthat will only hold theSavedObjecttype and a select few others. I'm not sure what the best approach here is. I have leftcore-saved-objects-api-serverunchanged for now (i.e., it is still importingSavedObjectfromcommonwhich is deprecated).Any input would be greatly appreciated!