[Cloud Posture] - Deprecate csp rule remove migration object #148530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfirpeled
reviewed
Jan 10, 2023
|
|
||
| export function setupSavedObjects(savedObjects: SavedObjectsServiceSetup) { | ||
| savedObjects.registerType<CspRule>({ |
There was a problem hiding this comment.
what happens once we stop registering the type to any existing csp_rule SO?
There was a problem hiding this comment.
I still need to check with the 8.6 to 8.7 upgrade.
But 8.7 clean slate works as expected
There was a problem hiding this comment.
All checked and done 👍
All flows work as expected (upgrading, etc)
kfirpeled
reviewed
Jan 10, 2023
| @@ -22,6 +22,8 @@ | |||
| "path": "../../../tsconfig.json", | |||
| "force": true | |||
| }, | |||
| "@kbn/security-plugin" | |||
| "@kbn/security-plugin", | |||
There was a problem hiding this comment.
Can you check if it's relevant for your PR?
There was a problem hiding this comment.
The file was removed once I updated the branch
pgayvallet
approved these changes
Jan 17, 2023
ofiriro3
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
ofiriro3
changed the title
💚 Build Succeeded
Metrics [docs]Saved Objects .kibana field count
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 24, 2023
* main: (54 commits) [APM] Allow calling `createInternalESClient` without `context` (elastic#149320) [Synthetics] Errors list active state (elastic#149387) [FTRs] Execution Context: fix no data flakiness (elastic#149406) [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530) Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521) [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883) [ML] Remove job_type from job definitions in modules (elastic#149247) [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224) [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142) [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945) [Lens] Enable previous time shift when using a date histogram (elastic#149126) [Synthetics] Object types panel and thresholds (elastic#149099) [Fleet] added back batch exec for update tags (elastic#148618) 148790 - Fix scroll style for setup guide flyout (elastic#149242) Fix a11y issue with dev tool tabs (elastic#149349) [APM] Fix mobile indices (elastic#149230) [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943) renderCustomActionsRow with named params instead of args (elastic#149304) [ML] Adding ML execution context to es requests (elastic#148746) [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We would like to deprecate the usage of the
csp_rule.Former PRs have removed the usage of this object, and now we wish to remove it from the loaded saved object.
This will be the final PR regarding this matter.
Related PRs
csp_rule- Engage the breaking change committee #147880