Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] Deprecate csp_rule - Engage the breaking change committee #147880

Closed
ofiriro3 opened this issue Dec 20, 2022 · 6 comments · Fixed by #148530
Closed

[Cloud Posture] Deprecate csp_rule - Engage the breaking change committee #147880

ofiriro3 opened this issue Dec 20, 2022 · 6 comments · Fixed by #148530
Labels
8.7 candidate Team:Cloud Security Cloud Security team related

Comments

@ofiriro3
Copy link
Contributor

ofiriro3 commented Dec 20, 2022 •
edited
Loading

Motivation
We no longer have a need for csp_rule SO and we would like to deprecate it.
Since removing a saved object from Kibana consider a breaking change we need to Engage the breaking change committee to approve this change.

BCC committee

Related tasks/epics
@ofiriro3 ofiriro3 added Team:Cloud Security Cloud Security team related 8.7 candidate labels Dec 20, 2022
@ofiriro3 ofiriro3 self-assigned this Dec 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

@ofiriro3 ofiriro3 mentioned this issue Dec 20, 2022
Closed
12 tasks
@ofiriro3
Copy link
Contributor Author

This request for the breaking change committee was created on December 7th - we are still waiting for a response from the BC team.

https://github.com/elastic/dev/issues/2179

@ofiriro3 ofiriro3 mentioned this issue Dec 21, 2022
Merged
@ofiriro3
Copy link
Contributor Author

After the committee has approved the change the saved-object registration of the csp-rule need to be removed as well

ofiriro3 added a commit that referenced this issue Dec 26, 2022
@ofiriro3 @kibanamachine
Deprecate csp rule (#147878)
81329da 
[Cloud-security-posture] - Deprecating `csp-rule`
## Summary
We no longer have a need in csp_rule SO. It is time to deprecate it
We would like to replace all the usage of the csp_rule with the csp_rule
template.

All kinds of migrations will be performed in a different PR related to
#147880


## Related issues
- #143523

Co-authored-by: kibanamachine <[email protected]>
@ofiriro3 ofiriro3 mentioned this issue Jan 9, 2023
Merged
@ofiriro3 ofiriro3 linked a pull request Jan 9, 2023 that will close this issue
[Cloud Posture] - Deprecate csp rule remove migration object #148530
Merged
@ofiriro3
Copy link
Contributor Author

ofiriro3 commented Jan 9, 2023 •
edited
Loading

There are two flows that have to be checked -

  • Installing 8.7 without any old integration
  • Using Kibana 8.6 with the old integration and data and migrating it to 8.7

@ofiriro3
Copy link
Contributor Author

ofiriro3 commented Jan 9, 2023

8.7 installation seems to work as expected:

image

@ofiriro3
Copy link
Contributor Author

I took an 8.6 installation and upgraded it to 8.7 - all works as expected.
Notify that I did it locally.

Image

@ofiriro3 ofiriro3 mentioned this issue Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.7 candidate Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cloud Posture] - Deprecate csp rule remove migration object ofiriro3/kibana
2 participants
@elasticmachine @ofiriro3