[Cloud Posture] fix findings table sort casing bug #148529
Conversation
orouz
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
ofiriro3
changed the title
| return { [sort.field]: sort.direction }; | ||
| }; | ||
|
|
||
| const requiredSortingByPainlessScript = ['rule.section', 'resource.name', 'resource.type']; |
There was a problem hiding this comment.
Hi @ofiriro3,
Forgive me if I need more context here. Would you mind adding a comment about why these fields require such a sorting instead of using a more native Elasticsearch solution like normalizer?
There was a problem hiding this comment.
Hi @opauloh.
We had a long discussion about how should we solve the sorting problem.
One of the solutions that I suggested was indeed a normalizer, in the end, it was decided to use a painless script.
Long story short, we didn't want to change the schema/mapping.
You are more than welcome to read the discussion ->
.../plugins/cloud_security_posture/public/pages/findings/latest_findings/use_latest_findings.ts
Outdated
Show resolved
Hide resolved
…test_findings/use_latest_findings.ts Co-authored-by: Paulo Henrique <[email protected]>
.../plugins/cloud_security_posture/public/pages/findings/latest_findings/use_latest_findings.ts
Show resolved
Hide resolved
x-pack/test/cloud_security_posture_functional/pages/findings.ts
Outdated
Show resolved
Hide resolved
|
|
||
| // We need to use a dataset for the tests to run | ||
| // We intentionally make some fields start with a capital letter to test that the query bar is case-insensitive/case-sensitive | ||
| const data = [ |
There was a problem hiding this comment.
defining the data is now longer and very focused on sorting. i think we can narrow it down a bit. for example, using single chars or shorter sentences would achieve the same result. and instead of doing chance.integer() % 2 ... multiple times, we can do it once and do the same for the text casing.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Currently our cloud-security-posture Findings page sort some fields with regard to case sensitivity, we would like them to be sorted in alphabetical order regardless of their upper case/lower case characters.
Related Findings fields
rule.sectionresource.nameresource.typeRelated issues: