Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Posture] fix findings table sort casing bug #148529
[Cloud Posture] fix findings table sort casing bug #148529
Changes from 7 commits
377e022
747bdcb
f19225d
e8a9c28
d454935
e041d1a
fc46845
6c40fe0
b7b04b3
e003f28
52ac325
75aac4a
38f1f0e
21ccfc7
29a3ca8
3ca5bae
9b105c6
f8bc2f9
3dd6205
16afec1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ofiriro3,
Forgive me if I need more context here. Would you mind adding a comment about why these fields require such a sorting instead of using a more native Elasticsearch solution like normalizer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @opauloh.
We had a long discussion about how should we solve the sorting problem.
One of the solutions that I suggested was indeed a normalizer, in the end, it was decided to use a painless script.
Long story short, we didn't want to change the schema/mapping.
You are more than welcome to read the discussion ->