Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTRs] Execution Context: fix no data flakiness #149406

Merged
merged 1 commit into from
Jan 24, 2023
Merged

[FTRs] Execution Context: fix no data flakiness #149406

merged 1 commit into from
Jan 24, 2023

Conversation

afharo
Copy link
Member

@afharo afharo commented Jan 24, 2023 •
edited by kibanamachine
Loading

Summary

Resolves #112102 (hopefully)

Another race condition in the tests was that no data was found when loading discover, so the charts were not requested. This PR extends the datepicker to the last 7 days (instead of the last 15 days).

On top of that, it makes sure that each assertion is an individual test, so we have better insight into which assertion failed.

Flaky Test runner (x100): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1781

Checklist

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Jan 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo self-assigned this Jan 24, 2023
@afharo afharo enabled auto-merge (squash) January 24, 2023 13:45
@afharo afharo requested a review from a team January 24, 2023 13:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit 09c1113 into elastic:main Jan 24, 2023
@afharo afharo deleted the execution-context-last-7-days branch January 24, 2023 14:03
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
❌ 8.6 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.6:
- Unskip Execution Context FTRs (#149070)

Manual backport

To create the backport manually run:

node scripts/backport --pr 149406

Questions ?

Please refer to the Backport tool documentation

@afharo afharo mentioned this pull request Jan 24, 2023
Closed
@afharo
Copy link
Member Author

afharo commented Jan 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

afharo added a commit to afharo/kibana that referenced this pull request Jan 24, 2023
@afharo
[FTRs] Execution Context: fix no data flakiness (elastic#149406)
392cf98 
Resolves elastic#112102

(cherry picked from commit 09c1113)

# Conflicts:
#	x-pack/test/functional_execution_context/tests/browser.ts
@afharo afharo mentioned this pull request Jan 24, 2023
Merged
@afharo
Copy link
Member Author

afharo commented Jan 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 24, 2023
@jloleysens
Merge branch 'main' into import-so-types-from-server
e1ec719 
* main: (54 commits)
  [APM] Allow calling `createInternalESClient` without `context` (elastic#149320)
  [Synthetics] Errors list active state (elastic#149387)
  [FTRs] Execution Context: fix no data flakiness (elastic#149406)
  [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530)
  Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521)
  [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883)
  [ML] Remove job_type from job definitions in modules (elastic#149247)
  [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224)
  [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142)
  [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945)
  [Lens] Enable previous time shift when using a date histogram (elastic#149126)
  [Synthetics] Object types panel and thresholds (elastic#149099)
  [Fleet] added back batch exec for update tags (elastic#148618)
  148790 - Fix scroll style for setup guide flyout (elastic#149242)
  Fix a11y issue with dev tool tabs (elastic#149349)
  [APM] Fix mobile indices (elastic#149230)
  [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943)
  renderCustomActionsRow with named params instead of args (elastic#149304)
  [ML] Adding ML execution context to es requests (elastic#148746)
  [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261)
  ...
@afharo afharo mentioned this pull request Jan 24, 2023
Merged
@afharo
Copy link
Member Author

afharo commented Jan 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

afharo added a commit to afharo/kibana that referenced this pull request Jan 24, 2023
@afharo
[FTRs] Execution Context: fix no data flakiness (elastic#149406)
6084239 
Resolves elastic#112102

(cherry picked from commit 09c1113)

# Conflicts:
#	x-pack/test/functional_execution_context/tests/browser.ts
afharo added a commit that referenced this pull request Jan 24, 2023
@afharo
[7.17] [FTRs] Execution Context: fix no data flakiness (#149406) (#14…
b7a67c3 
…9417)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[FTRs] Execution Context: fix no data flakiness
(#149406)](#149406)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-24T14:03:37Z","message":"[FTRs]
Execution Context: fix no data flakiness (#149406)\n\nResolves
https://github.com/elastic/kibana/issues/112102","sha":"09c11131271bec1b794d5a472294e6e125116f4d","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.7.0"],"number":149406,"url":"https://github.com/elastic/kibana/pull/149406","mergeCommit":{"message":"[FTRs]
Execution Context: fix no data flakiness (#149406)\n\nResolves
https://github.com/elastic/kibana/issues/112102","sha":"09c11131271bec1b794d5a472294e6e125116f4d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/149406","number":149406,"mergeCommit":{"message":"[FTRs]
Execution Context: fix no data flakiness (#149406)\n\nResolves
https://github.com/elastic/kibana/issues/112102","sha":"09c11131271bec1b794d5a472294e6e125116f4d"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v7.17.9 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 24, 2023
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

afharo added a commit that referenced this pull request Jan 26, 2023
@afharo
[8.6] [FTRs] Execution Context: fix no data flakiness (#149406) (#149425
c3ca358 
)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[FTRs] Execution Context: fix no data flakiness
(#149406)](#149406)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-24T14:03:37Z","message":"[FTRs]
Execution Context: fix no data flakiness (#149406)\n\nResolves
https://github.com/elastic/kibana/issues/112102","sha":"09c11131271bec1b794d5a472294e6e125116f4d","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.7.0"],"number":149406,"url":"https://github.com/elastic/kibana/pull/149406","mergeCommit":{"message":"[FTRs]
Execution Context: fix no data flakiness (#149406)\n\nResolves
https://github.com/elastic/kibana/issues/112102","sha":"09c11131271bec1b794d5a472294e6e125116f4d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/149406","number":149406,"mergeCommit":{"message":"[FTRs]
Execution Context: fix no data flakiness (#149406)\n\nResolves
https://github.com/elastic/kibana/issues/112102","sha":"09c11131271bec1b794d5a472294e6e125116f4d"}},{"url":"https://github.com/elastic/kibana/pull/149417","number":149417,"branch":"7.17","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.6.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 26, 2023
@mistic mistic added v8.6.2 and removed v8.6.1 labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

@afharo afharo

Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.9 v8.6.2 v8.7.0
Projects
None yet
Milestone
No milestone
6 participants
@afharo @elasticmachine @kibana-ci @kibanamachine @pgayvallet @mistic