Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fix Phrase_filter query for scripted fields (#148942) #148943

Merged
merged 8 commits into from
Jan 24, 2023
Merged

[Dashboard] Fix Phrase_filter query for scripted fields (#148942) #148943

merged 8 commits into from
Jan 24, 2023

Conversation

dawn023349
Copy link
Contributor

@dawn023349
[Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942)
0404ad0 
- ISSUE
[Dashboard] Visualize Library doesn't work filter on scripted fields of Array Type. elastic#148942
@dawn023349 dawn023349 requested a review from a team as a code owner January 15, 2023 16:13
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 15, 2023 •
edited
Loading

💚 CLA has been signed

@dawn023349 dawn023349 mentioned this pull request Jan 18, 2023
Closed
@stratoula
Copy link
Contributor

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

buildkite, test this

@kertal kertal requested review from a team and lukasolson January 18, 2023 16:06
lukasolson
lukasolson reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawn023349 Thanks for your contribution! If you don't mind, could you take a look at the failing tests and fix them before we can merge this?

@dawn023349
Copy link
Contributor Author

Thanks for your review @lukasolson .

sure, I’ll check it.

@dawn023349
Copy link
Contributor Author

dawn023349 commented Jan 23, 2023 •
edited
Loading

@lukasolson !
I confirmed that I did not modify "phrase_filter.test.ts".
and
I Fixed(commit) that.

Can you review it again?

@lukasolson lukasolson added Feature:Filters Feature:Scripted Fields Scripted fields features Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson enabled auto-merge (squash) January 23, 2023 21:43
@stratoula
Copy link
Contributor

buildkite, test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.2MB 2.2MB +110.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@lukasolson lukasolson merged commit 95c2493 into elastic:main Jan 24, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Jan 24, 2023
@dawn023349
Copy link
Contributor Author

@stratoula @lukasolson
Thank you for checking the immature request.
I'm glad to be a merge.

I wish you a Happy New Year!😄
hope to see you again sometime.
Thank You.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 24, 2023
@jloleysens
Merge branch 'main' into import-so-types-from-server
e1ec719 
* main: (54 commits)
  [APM] Allow calling `createInternalESClient` without `context` (elastic#149320)
  [Synthetics] Errors list active state (elastic#149387)
  [FTRs] Execution Context: fix no data flakiness (elastic#149406)
  [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530)
  Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521)
  [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883)
  [ML] Remove job_type from job definitions in modules (elastic#149247)
  [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224)
  [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142)
  [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945)
  [Lens] Enable previous time shift when using a date histogram (elastic#149126)
  [Synthetics] Object types panel and thresholds (elastic#149099)
  [Fleet] added back batch exec for update tags (elastic#148618)
  148790 - Fix scroll style for setup guide flyout (elastic#149242)
  Fix a11y issue with dev tool tabs (elastic#149349)
  [APM] Fix mobile indices (elastic#149230)
  [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943)
  renderCustomActionsRow with named params instead of args (elastic#149304)
  [ML] Adding ML execution context to es requests (elastic#148746)
  [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community Feature:Filters Feature:Scripted Fields Scripted fields features release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dawn023349 @kibanamachine @stratoula @elasticmachine @kibana-ci @lukasolson