-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Object types panel and thresholds #149099
Conversation
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Shows the size trend in neutral color when the tooltip does show variance. See the attached video, it displays no change via color whereas in tooltip, it does show value has varied.
- Next check works but Previous check button doesn't. See at the end of the attached video.
object-weight-static-bar-for-neg-change.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested creating a new monitor with two steps. Here are the observations:
Monitor used:
step('Goto IKEA', async () => {
await page.goto('https://ikea.com');
});
step('Goto Lidl', async () => {
if(Math.random() > 0.5) {
await page.waitForSelector('text=Non-Exitent', { timeout: 500 });
}
await page.goto('https://lidl.com');
}) ;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Works as expected now.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
* main: (54 commits) [APM] Allow calling `createInternalESClient` without `context` (elastic#149320) [Synthetics] Errors list active state (elastic#149387) [FTRs] Execution Context: fix no data flakiness (elastic#149406) [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530) Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521) [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883) [ML] Remove job_type from job definitions in modules (elastic#149247) [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224) [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142) [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945) [Lens] Enable previous time shift when using a date histogram (elastic#149126) [Synthetics] Object types panel and thresholds (elastic#149099) [Fleet] added back batch exec for update tags (elastic#148618) 148790 - Fix scroll style for setup guide flyout (elastic#149242) Fix a11y issue with dev tool tabs (elastic#149349) [APM] Fix mobile indices (elastic#149230) [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943) renderCustomActionsRow with named params instead of args (elastic#149304) [ML] Adding ML execution context to es requests (elastic#148746) [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261) ...
Summary
Fixes #145395
Fixes #145892