Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Object types panel and thresholds #149099

Merged
merged 14 commits into from
Jan 24, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jan 18, 2023

Summary

Fixes #145395
Fixes #145892

image

@shahzad31 shahzad31 marked this pull request as ready for review January 18, 2023 10:52
@shahzad31 shahzad31 requested a review from a team as a code owner January 18, 2023 10:52
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 and removed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 18, 2023
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Shows the size trend in neutral color when the tooltip does show variance. See the attached video, it displays no change via color whereas in tooltip, it does show value has varied.
  • Next check works but Previous check button doesn't. See at the end of the attached video.
object-weight-static-bar-for-neg-change.mov

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 18, 2023
@shahzad31 shahzad31 requested a review from awahab07 January 18, 2023 16:05
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested creating a new monitor with two steps. Here are the observations:

Runs step 1 step 2
1st 1st run - IKEA - 1st stepa comparison is shown despite being the 1st ever run 1st run - Lidl - 2nd stepfirst successful run of step 2
2nd 2nd run - IKEA - 1st stepstep failed here, should a comparison be shown when step doesn't have data for a MIME Type skipped
3rd 3rd run - IKEA - 1st stepvalue is same as with 1st run but a 14% rise is indicated failed
4th 4th run - IKEA - 1st stepvalue is same as with 1st and 3rd run but a 14% rise is indicated failed
5th failed
6th 6th run - Lidl- 2nd stepit's the 2nd time the 2nd step has data (2nd successful run), should a comparison be shown with the previous run

Monitor used:

step('Goto IKEA', async () => {
    await page.goto('https://ikea.com');
});

step('Goto Lidl', async () => {
    if(Math.random() > 0.5) {
        await page.waitForSelector('text=Non-Exitent', { timeout: 500 });
    }
    
    await page.goto('https://lidl.com');
}) ;

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Works as expected now.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #47 / machine learning - data visualizer index based "before all" hook in "index based"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1336 1337 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.3MB 1.4MB +3.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit d692d40 into elastic:main Jan 24, 2023
@shahzad31 shahzad31 deleted the object-type-panel branch January 24, 2023 10:12
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 24, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 24, 2023
* main: (54 commits)
  [APM] Allow calling `createInternalESClient` without `context` (elastic#149320)
  [Synthetics] Errors list active state (elastic#149387)
  [FTRs] Execution Context: fix no data flakiness (elastic#149406)
  [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530)
  Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521)
  [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883)
  [ML] Remove job_type from job definitions in modules (elastic#149247)
  [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224)
  [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142)
  [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945)
  [Lens] Enable previous time shift when using a date histogram (elastic#149126)
  [Synthetics] Object types panel and thresholds (elastic#149099)
  [Fleet] added back batch exec for update tags (elastic#148618)
  148790 - Fix scroll style for setup guide flyout (elastic#149242)
  Fix a11y issue with dev tool tabs (elastic#149349)
  [APM] Fix mobile indices (elastic#149230)
  [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943)
  renderCustomActionsRow with named params instead of args (elastic#149304)
  [ML] Adding ML execution context to es requests (elastic#148746)
  [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0
Projects
None yet
5 participants