kibana API plugin #12390
Closed
kibana API plugin #12390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add kibana API plugin
Add kibana API plugin
|
Can one of the admins verify this patch? |
Add kibana API plugin
* remove Private module loader from FieldFormat * remove dependency on bound_to_config_obj * update field_formats registry getDefaultInstanc and getInstance to pass getConfig to FieldFormat constructors * make previous changes work * remove paramDefaults state from FieldFormat class, instead use getter * remove use of shortDotsFilter in source field formatter * fix broken tests * remove angular dependency from field formatters * fix _conformance test * getConfig service and replace with inline function * remove unneeded ngMock from __tests__/_field_format.js * use JSON.stringify in content_types instead of aggressive_parse.tojson because function is only converting an array of strings to into a string * pass getParamDefaults to _numeral in opts argument * update field format editors to handle moving paramDefaults from class to instance via getter * remove unneeded reference to self * change to arrow functions * change content_type export from object to only the setup function * remove unneeded function block around simple arrow function
In order for render-count to be implemented correctly, we need to trigger it’s completion when there are no results.
* Add new react color picker to ui framework with tests In prep for dashboard color customization. * address code review comments * second round of feedback * nativeEvent not available in a headless browser, so jenkins tests will fail without a check * move aria-label * Require color and have components pass undefined to use default color * update snapshots after aria-label move * get rid of default color * user display: inline-block so clickable is only the width of box and lab el
* provide getFormat function to date_histogram * move format object creation to time_buckets * fix broken test * pass getConfig to field format constructor since field formatters no longer manage config themselves * fix _agg_config testing of agg without getFormat method. Old test used date_histogram which now has getFormat, so needed a new agg type * update expect values for area chart data * fix expect for visualize app vertical bar * fix expect for visualize app heatmap chart
* fixing container too small message * moving minBarWidth definition to the top * removing container too small message from point series * remove tests
Add kibana API plugin
|
@ytzlax Thanks for this PR, but it looks like the history may have diverged from that of |
cjcenizal
added
Team:Core
|
Hi @cjcenizal , |
|
Thanks! Closing in favor of #13206. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kibana API plugin, to known plugins