In case of a save error, use notify.error, not a full screen fatal page #12381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stacey-gammon any chance we can get this backported to 5.5 for the new demo site? |
|
Also, this was seen when attempting to save a visualization as well. Would this fix resolve the viz side of this as well? |
|
Will do @alexfrancoeur - and yes, this covers visualizations as well. |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 19, 2017
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 19, 2017
This was referenced Jun 19, 2017
stacey-gammon
added a commit
that referenced
this pull request
Jun 19, 2017
stacey-gammon
added a commit
that referenced
this pull request
Jun 19, 2017
|
Thank you @stacey-gammon!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the fatal screen when a save fails, only use the notification error banner.