Scaled date format for date histogram aggregation #12384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Visualizations
There was a problem hiding this comment.
nice fix, unit tests here need a little TLC https://github.com/thomasneirynck/kibana/blob/4bc4c58d8ce63225618b1dc207cc31f5c9c2fd00/src/ui/public/agg_table/__tests__/_table.js#L113-L113
stacey-gammon
approved these changes
Jun 19, 2017
|
Should |
|
your call. I'm good with what it's now. these aren't called in a tight loop. there's repeated instance-creation, when rendering results, but that's only a single time. e.g. these objects arent' created repeatedly on each frame. |
nreese
force-pushed
the
dateFormat_scaled
branch
from
b607a78 to
4339982
Compare
…longer manage config themselves
…d date_histogram which now has getFormat, so needed a new agg type
|
@nreese Release Note: paragraph in the description please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getFormatfunction to date_histogramBucketAggType. The function will return a DateFieldFormatter configured with a scaled date format as specified under advanced settingsdateFormat:scaled.fixes #8076
Release Note:
Format date_histogram aggregation bucket labels with format specified in Advanced Setting's "dateFormat:scaled"