Move Jest config to json #12402
Merged
Move Jest config to json #12402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
reviewed
Jun 19, 2017
package.json
Outdated
| @@ -94,7 +94,7 @@ | |||
| "autoprefixer-loader": "2.0.0", | |||
| "babel-cli": "6.18.0", | |||
| "babel-core": "6.21.0", | |||
| "babel-jest": "20.0.0", | |||
| "babel-jest": "^20.0.3", | |||
There was a problem hiding this comment.
We're locking the rest of our dependencies to specific versions. Any reason to deviate for these dependencies?
There was a problem hiding this comment.
Bah, we really need to switch to Yarn. Fixed
kimjoar
added a commit
to kimjoar/kibana
that referenced
this pull request
Jun 21, 2017
kimjoar
added a commit
that referenced
this pull request
Jun 21, 2017
|
5.x: eb11977 |
jimgoodwin
added
release_note:enhancement
Team:Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the Jest config to a JSON file instead of having it in JS and stringifying it etc. This makes it simpler to for example run debugger on the Jest tests (see https://facebook.github.io/jest/docs/troubleshooting.html).
(The only change is removing the
resolveand "hard-coding" the path to the babel transform)