Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New known plugin #13206

Merged
merged 4 commits into from
Aug 2, 2017
Merged

New known plugin #13206

merged 4 commits into from
Aug 2, 2017

Conversation

ytzlax
Copy link
Contributor

@ytzlax ytzlax commented Jul 30, 2017

Kibana API

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@ytzlax ytzlax mentioned this pull request Jul 30, 2017
@cjcenizal cjcenizal added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Docs labels Jul 30, 2017
@thomasneirynck
Copy link
Contributor

jenkins, test this

@thomasneirynck thomasneirynck self-requested a review July 31, 2017 18:16
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ytzlax, happy to add this to Kibana. Small suggestion wrt. language.

@@ -47,5 +47,6 @@ This list of plugins is not guaranteed to work on your version of Kibana. Instea
[float]
=== Other
* https://github.com/nreese/kibana-time-plugin[Time picker as a dashboard panel] Widget to view and edit the time range from within dashboards.
* https://github.com/Webiks/kibana-API.git[Kibana-API] (webiks) Expose kibana functionality to your application, like create visualization dynamiclly, delete visualization and more..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tidy up the language a little bit?

e.g. :Exposes an API with Kibana functionality. Use it to create, edit and embed visualizations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thomasneirynck,
I change it a little, what you think?

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, tgx. one small typo in embedded

@@ -48,4 +48,8 @@ This list of plugins is not guaranteed to work on your version of Kibana. Instea
=== Other
* https://github.com/nreese/kibana-time-plugin[Time picker as a dashboard panel] Widget to view and edit the time range from within dashboards.

* https://github.com/Webiks/kibana-API.git[Kibana-API] (webiks) Exposes an API with Kibana functionality.
Use it to create, edit and embed visualizations, and also to search inside embeded dashboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use it to create, edit and embed visualizations, and also to search inside an embedded dashboard.

@ytzlax
Copy link
Contributor Author

ytzlax commented Aug 2, 2017

@thomasneirynck,
done

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Aug 2, 2017

Backports:
6.x: 1ea3f6b
6.0: a6c6129
5.6: 84c6c86
5.5: 9cde52b

thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Aug 2, 2017
thomasneirynck pushed a commit that referenced this pull request Aug 2, 2017
thomasneirynck pushed a commit that referenced this pull request Aug 2, 2017
thomasneirynck pushed a commit that referenced this pull request Aug 2, 2017
thomasneirynck pushed a commit that referenced this pull request Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Docs v5.5.2 v5.6.0 v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants