Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Update label if operation and field are changed at once #100991

Merged
merged 3 commits into from
Jun 2, 2021
Merged

[Lens] Update label if operation and field are changed at once #100991

merged 3 commits into from
Jun 2, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #100989

Reverts to default label if operation and field are changed at the same time (e.g. by dragging in a field which is not compatible with the current operation)

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 31, 2021
@flash1293 flash1293 marked this pull request as ready for review May 31, 2021 13:50
@flash1293 flash1293 requested a review from a team May 31, 2021 13:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra
Copy link
Contributor

mbondyra commented Jun 2, 2021

@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

mbondyra commented Jun 2, 2021 •
edited
Loading

Tested on FF and works fine. There is one more case that for me feels off: dragging a new field to replace existing operation with custom label. I feel like when only the field is changed we should reset the label as well. Let me know what you think about it and if needed to be addressed, if you prefer me to open a new issue or fix it here.

Jun-02-2021 09-45-56

@flash1293
Copy link
Contributor Author

It's hard to always do the right thing for custom labels - I didn't change the behavior for changing field because the user could pick a name without mentioning the field because it's implied by the context (e.g. 95th percentile). In that case reverting to the default label and adding the field back would be annoying.

I think reverting to default if both operation and field are changed is safer because there aren't much options what the label would refer to in this situation.

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Jun 2, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +234.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 65dbcdd into elastic:master Jun 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 2, 2021
@flash1293 @kibanamachine
change label behavior (elastic#100991)
7ab4362
@kibanamachine kibanamachine mentioned this pull request Jun 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 2, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
2b9bd67 
* master: (68 commits)
  Unskip advanced settings a11y test (elastic#100558)
  [App Search] Crawler Landing Page (elastic#100822)
  [DOCS] Clarify when to use kbn clean (elastic#101155)
  change label behavior (elastic#100991)
  skip flaky suite (elastic#101126)
  Fix cases plugin ownership (elastic#101073)
  [Home] Adding file upload to add data page (elastic#100863)
  [ML] Functional tests - reenable categorization tests (elastic#101137)
  [DOCS] Adds server.uuid to settings docs (elastic#101121)
  Fix newsfeed unread notifications always on when reloading Kibana (elastic#100357)
  [Lens] Time shift metrics (elastic#98781)
  [Deprecations service] make `correctiveActions.manualSteps` required (elastic#100997)
  Add "Risk Matrix" section to the PR template (elastic#100649)
  [Maps] spatially filter by all geo fields (elastic#100735)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  ...
kibanamachine added a commit that referenced this pull request Jun 2, 2021
@kibanamachine @flash1293
change label behavior (#100991) (#101172)
9bcb0ae 
Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Do not keep label if both operation and field changes
4 participants
@flash1293 @elasticmachine @mbondyra @kibanamachine