Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Do not keep label if both operation and field changes #100989

Closed
flash1293 opened this issue May 31, 2021 · 1 comment · Fixed by #100991
Closed

[Lens] Do not keep label if both operation and field changes #100989

flash1293 opened this issue May 31, 2021 · 1 comment · Fixed by #100991
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

At the moment the custom label a user specified is respected and kept for most operations the user does. However in some situations this is not a good default, because the custom label is unlikely so still properly reflect the meaning of a dimension.

If a user is changing both used operation and field in a single operation (e.g. by dragging a field to a dimension which is not compatible with the current operation), there is no reason to assume the user specified label still makes sense. In this situation the default label should overwrite the custom label.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels May 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants