Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Crawler Landing Page #100822

Merged
merged 13 commits into from
Jun 2, 2021
Merged

[App Search] Crawler Landing Page #100822

merged 13 commits into from
Jun 2, 2021

Conversation

byronhulcher
Copy link
Contributor

Summary

Informational landing page for Kibana users to direct them to the standalone App Search UX for the Crawler in 7.14

Screenshots

Screen Shot 2021-05-27 at 3 46 06 PM

Screen Shot 2021-05-27 at 3 46 23 PM

Screen Shot 2021-05-27 at 3 46 33 PM

@byronhulcher byronhulcher self-assigned this May 27, 2021
@byronhulcher byronhulcher added v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Feature:Plugins labels May 27, 2021
@byronhulcher byronhulcher force-pushed the crawler-landing-page branch from ebb2a5c to f56586e Compare May 28, 2021 00:18
@byronhulcher byronhulcher marked this pull request as ready for review May 28, 2021 00:18
@byronhulcher byronhulcher requested a review from a team May 28, 2021 00:18
cee-chen
cee-chen reviewed May 28, 2021
View reviewed changes
x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/constants.ts
@@ -9,5 +9,5 @@ import { i18n } from '@kbn/i18n';

export const CRAWLER_TITLE = i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.crawler.title',
{ defaultMessage: 'Crawler' }
{ defaultMessage: 'Web Crawler' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the copy in the navigation link as well - are we good with that? I'm fine either way, maybe would just double check with @daveyholler

@cee-chen
Copy link
Contributor

That's it for my (hopefully mostly minor comments) - design looks great, thanks Byron! Maybe my only other question would be if we ran the png graphic through tinypng.com or similar, just in case (since Kibana tracks asset sizes). If we did, awesome, no worries! 🎉

@byronhulcher byronhulcher requested a review from JasonStoltz June 1, 2021 14:07
@byronhulcher
Copy link
Contributor Author

Maybe my only other question would be if we ran the png graphic through tinypng.com or similar, just in case (since Kibana tracks asset sizes).

I've addressed this in b7d82d9

@byronhulcher
Copy link
Contributor Author

@JasonStoltz Since @constancecchen is out this week I've added you as a reviewer to this. I've addressed all of Constance's feedback, but obviously I'm happy to take care of anything you find as well.

cee-chen
cee-chen approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great! Thanks for the commit diff links as well, made it super easy to re-review 😍

(Also don't yell at me too much for code reviewing on my day off haha, I woke up too early and now I'm sitting here waiting for Michael's to open and I'm bored as heck)

@cee-chen
Copy link
Contributor

cee-chen commented Jun 1, 2021

Super weird, looks like just CI shenanigans

@cee-chen
Copy link
Contributor

cee-chen commented Jun 1, 2021

@elasticmachine merge upstream

@byronhulcher
Update x-pack/plugins/enterprise_search/public/applications/app_searc…
4f57dbe 
…h/components/crawler/crawler_landing.scss

Co-authored-by: Constance <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1398 1410 +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +7.2KB
Unknown metric groups

miscellaneous assets size

id before after diff
enterpriseSearch 872.7KB 886.8KB +14.2KB

References to deprecated APIs

id before after diff
canvas 29 25 -4
fleet 22 20 -2
lens 67 45 -22
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -93

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

@byronhulcher byronhulcher merged commit 90f2d09 into elastic:master Jun 2, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 2, 2021
@byronhulcher @kibanamachine
[App Search] Crawler Landing Page (elastic#100822)
8ec5296 
* New CrawlerLanding component

* New CrawlerRouter component

* Adding CrawlerRouter to EngineRouter

* Using internal route for Crawler link in EngineNav

* Rename crawler landing background

* Fix CrawlerLanding css

* Fix crawler documentation link

* Add Crawler title to breadcrumbs

* Reduce png filesize

* Improve CrawlerLanding copy

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_landing.scss

Co-authored-by: Constance <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Constance <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Jun 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 2, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
2b9bd67 
* master: (68 commits)
  Unskip advanced settings a11y test (elastic#100558)
  [App Search] Crawler Landing Page (elastic#100822)
  [DOCS] Clarify when to use kbn clean (elastic#101155)
  change label behavior (elastic#100991)
  skip flaky suite (elastic#101126)
  Fix cases plugin ownership (elastic#101073)
  [Home] Adding file upload to add data page (elastic#100863)
  [ML] Functional tests - reenable categorization tests (elastic#101137)
  [DOCS] Adds server.uuid to settings docs (elastic#101121)
  Fix newsfeed unread notifications always on when reloading Kibana (elastic#100357)
  [Lens] Time shift metrics (elastic#98781)
  [Deprecations service] make `correctiveActions.manualSteps` required (elastic#100997)
  Add "Risk Matrix" section to the PR template (elastic#100649)
  [Maps] spatially filter by all geo fields (elastic#100735)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  ...
kibanamachine added a commit that referenced this pull request Jun 2, 2021
@kibanamachine @byronhulcher
[App Search] Crawler Landing Page (#100822) (#101175)
2a52938 
* New CrawlerLanding component

* New CrawlerRouter component

* Adding CrawlerRouter to EngineRouter

* Using internal route for Crawler link in EngineNav

* Rename crawler landing background

* Fix CrawlerLanding css

* Fix crawler documentation link

* Add Crawler title to breadcrumbs

* Reduce png filesize

* Improve CrawlerLanding copy

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_landing.scss

Co-authored-by: Constance <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Constance <[email protected]>

Co-authored-by: Byron Hulcher <[email protected]>
Co-authored-by: Constance <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

@JasonStoltz JasonStoltz Awaiting requested review from JasonStoltz

Assignees

@byronhulcher byronhulcher

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byronhulcher @cee-chen @kibanamachine