Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - reenable categorization tests #101137

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jun 2, 2021

Summary

This PR re-enables the categorization tests that have been temporarily skipped in #101057.

Details

It seems for the combination of the small test data and validations we're running, the backend changes didn't have any impact on the test results. So this is just re-enabling the tests without change.
I've also sneaked in two missing spaces in log messages.

Closes #101056

@pheyos pheyos requested review from darnautov and jgowdyelastic June 2, 2021 07:14
@pheyos pheyos self-assigned this Jun 2, 2021
@pheyos pheyos requested a review from a team as a code owner June 2, 2021 07:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Jun 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@pheyos pheyos merged commit f4f8ea7 into elastic:master Jun 2, 2021
@pheyos pheyos deleted the reenable_categorization_tests branch June 2, 2021 14:32
@pheyos
Copy link
Member Author

pheyos commented Jun 2, 2021

Holding back the backport until elastic/elasticsearch/pull/73605 is included in a promoted 7.14 ES snapshot.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 2, 2021
* master: (68 commits)
  Unskip advanced settings a11y test (elastic#100558)
  [App Search] Crawler Landing Page (elastic#100822)
  [DOCS] Clarify when to use kbn clean (elastic#101155)
  change label behavior (elastic#100991)
  skip flaky suite (elastic#101126)
  Fix cases plugin ownership (elastic#101073)
  [Home] Adding file upload to add data page (elastic#100863)
  [ML] Functional tests - reenable categorization tests (elastic#101137)
  [DOCS] Adds server.uuid to settings docs (elastic#101121)
  Fix newsfeed unread notifications always on when reloading Kibana (elastic#100357)
  [Lens] Time shift metrics (elastic#98781)
  [Deprecations service] make `correctiveActions.manualSteps` required (elastic#100997)
  Add "Risk Matrix" section to the PR template (elastic#100649)
  [Maps] spatially filter by all geo fields (elastic#100735)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  ...
@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 3, 2021
This PR re-enables the categorization tests that have been temporarily skipped.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 3, 2021
)

This PR re-enables the categorization tests that have been temporarily skipped.

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional test-api-integration v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Functional tests - categorization tests are temporarily skipped
4 participants