[Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards #101034

dasansol92 · 2021-06-01T09:08:48Z

Summary

Adds new unit tests for new components from this other PR

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

…_to_the_fleet_endpoint_tab-1157

…core, adding aggs type, validating response, and more

…d small improvements on test -> ts

…_to_the_fleet_endpoint_tab-1157

…_endpoint_tab-1157' of github.com:dasansol92/kibana into feature/olm-add_event_filters_summary_card_to_the_fleet_endpoint_tab-1157

…_to_the_fleet_endpoint_tab-1157

elasticmachine · 2021-06-01T10:02:38Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

academo · 2021-06-01T11:06:20Z

...er_integration/endpoint_package_custom_extension/components/exception_items_summary.test.tsx

+  it('should renders correctly when missing some stats', () => {
+    const summary: Partial<GetExceptionSummaryResponse> = {
+      windows: 3,
+      total: 3,


Do we need a test case to check if the total is missing? is that a possible case?

Yes, that's possible but in the component each item is parsed in the same way, so if some key is missing, a 0 will be displayed instead

academo · 2021-06-01T11:19:16Z

...ngest_manager_integration/endpoint_package_custom_extension/components/styled_components.tsx

@@ -14,11 +14,11 @@ export const StyledEuiFlexGridGroup = styled(EuiFlexGroup)`
 `;

 export const StyledEuiFlexGridItem = styled(EuiFlexItem)<{
-  gridArea: string;
-  alignItems?: string;
+  gridarea: string;


is this change and the following intended? (removing the camel case)

Yes! This is to remove a react warning for non recognized attributes:

Warning: React does not recognize the `alignItems` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `alignitems` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

ashokaditya

🚀 LGTM. I have only a bunch of nitpicks.

ashokaditya · 2021-06-01T11:06:29Z

...ngest_manager_integration/endpoint_package_custom_extension/components/styled_components.tsx

@@ -14,11 +14,11 @@ export const StyledEuiFlexGridGroup = styled(EuiFlexGroup)`
 `;

 export const StyledEuiFlexGridItem = styled(EuiFlexItem)<{
-  gridArea: string;
-  alignItems?: string;
+  gridarea: string;


Out of curiosity? Why was a change to flat case needed?

To avoid this react warning:

Warning: React does not recognize the `alignItems` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `alignitems` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

ashokaditya · 2021-06-01T11:10:40Z

...manager_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.tsx

    const fetchStats = async () => {
      try {
        const response = await trustedAppsApi.getTrustedAppsSummary();
-        setStats(response);
+        if (isMounted) setStats(response);


nitpick: I feel it's more readable with {} around a single statement.

ashokaditya · 2021-06-01T11:12:10Z

...er_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.test.tsx

+      };
+    });
+  });
+  it('should renders correctly', async () => {


nitpick: should render...

ashokaditya · 2021-06-01T11:12:17Z

...er_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.test.tsx

+    expect(component.getByText('Trusted Applications')).not.toBeNull();
+    expect(component.getByText('Manage trusted applications')).not.toBeNull();
+  });
+  it('should renders an error when api call fails', async () => {


nitpick: should render...

ashokaditya · 2021-06-01T11:15:36Z

...er_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.test.tsx

+  afterEach(() => {
+    TrustedAppsHttpServiceMock.mockReset();
+  });
+  beforeEach(() => {


nitpick: semantically it makes sense to keep all before.. methods before after... methods. So beforeAll followed by beforeEach and then afterEach at the end.

ashokaditya · 2021-06-01T11:19:48Z

...er_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.test.tsx

+    expect(component.getByText('Trusted Applications')).not.toBeNull();
+    expect(component.getByText('Manage trusted applications')).not.toBeNull();
+  });
+  it('should renders an error when api call fails', async () => {


nitpick: I think it's okay to have test descriptions with even more context. This one renders an error toast and should say something like should render an error toast when.... That way one doesn't have to read the code to know what this test is verifying.

ashokaditya · 2021-06-01T11:22:26Z

...r_integration/endpoint_package_custom_extension/components/fleet_event_filters_card.test.tsx

+    }
+    return component;
+  };
+  afterEach(() => {


nitpick: semantically it makes sense to keep all before... methods before after... methods. So beforeAll followed by beforeEach and then afterEach at the end.

ashokaditya · 2021-06-01T11:23:11Z

...r_integration/endpoint_package_custom_extension/components/fleet_event_filters_card.test.tsx

+      };
+    });
+  });
+  it('should renders correctly', async () => {


nitpick: ...render...

ashokaditya · 2021-06-01T11:24:31Z

...er_integration/endpoint_package_custom_extension/components/exception_items_summary.test.tsx

+    });
+    return component;
+  };
+  it('should renders correctly', () => {


nitpick: ...render...

ashokaditya · 2021-06-01T11:27:08Z

...r_integration/endpoint_package_custom_extension/components/fleet_event_filters_card.test.tsx

+    expect(component.getByText('Event Filters')).not.toBeNull();
+    expect(component.getByText('Manage event filters')).not.toBeNull();
+  });
+  it('should renders an error when api call fails', async () => {


nitpick: should render an error toast when api call fails

kibanamachine · 2021-06-01T14:03:54Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.9MB	6.9MB	+258.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`canvas`	29	25	-4
`crossClusterReplication`	8	6	-2
`fleet`	22	20	-2
`globalSearch`	4	2	-2
`indexManagement`	12	7	-5
`infra`	261	149	-112
`lens`	67	45	-22
`licensing`	18	15	-3
`lists`	239	236	-3
`maps`	286	208	-78
`ml`	121	115	-6
`monitoring`	109	56	-53
`securitySolution`	390	346	-44
`stackAlerts`	101	95	-6
total			-342

History

💔 Build #128276 failed eaae47d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…trusted apps cards (elastic#101034) * Adds new unit tests for fleet card components * Fixes some warnings on ui * Adds some syntax and readibility nits comming from pr comments Co-authored-by: Kibana Machine <[email protected]>

…sens/kibana into reporting/new-png-pdf-report-type * 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits) [Security Solution] Add Ransomware canary advanced policy option (elastic#101068) [Exploratory view] Core web vitals (elastic#100320) [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034) [Lens] Use a setter function for the dimension panel (elastic#101123) [Index Patterns] Fix return saved index pattern object (elastic#101051) [CI] For PRs, build TS refs before public api docs check (elastic#100791) [Maps] fix line and polygon label regression (elastic#101085) Migrate CCR to new ES JS client. (elastic#100131) [Canvas] Switch Canvas to use React Router (elastic#100579) [Expressions] Use table column ID instead of name when set (elastic#99724) [DOCS] Updates docs landing page (elastic#100749) [DOCS] Corrects typo in step 3 (elastic#101079) [DOCS] Updates runtime example in Discover (elastic#100926) Migrate kibana.autocomplete config to data plugin (elastic#100586) [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147) [FTR] Use importExport for saved_object/basic archive (elastic#100244) [Fleet] Better input for multi text input in agent policy builder (elastic#101020) [CI] Buildkite support with Baseline pipeline (elastic#100492) [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388) Create API keys with metadata (elastic#100682) ...

* master: (68 commits) Unskip advanced settings a11y test (elastic#100558) [App Search] Crawler Landing Page (elastic#100822) [DOCS] Clarify when to use kbn clean (elastic#101155) change label behavior (elastic#100991) skip flaky suite (elastic#101126) Fix cases plugin ownership (elastic#101073) [Home] Adding file upload to add data page (elastic#100863) [ML] Functional tests - reenable categorization tests (elastic#101137) [DOCS] Adds server.uuid to settings docs (elastic#101121) Fix newsfeed unread notifications always on when reloading Kibana (elastic#100357) [Lens] Time shift metrics (elastic#98781) [Deprecations service] make `correctiveActions.manualSteps` required (elastic#100997) Add "Risk Matrix" section to the PR template (elastic#100649) [Maps] spatially filter by all geo fields (elastic#100735) [Security Solution] Add Ransomware canary advanced policy option (elastic#101068) [Exploratory view] Core web vitals (elastic#100320) [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034) [Lens] Use a setter function for the dimension panel (elastic#101123) [Index Patterns] Fix return saved index pattern object (elastic#101051) [CI] For PRs, build TS refs before public api docs check (elastic#100791) ...

…trusted apps cards (#101034) (#101151) * Adds new unit tests for fleet card components * Fixes some warnings on ui * Adds some syntax and readibility nits comming from pr comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

dasansol92 and others added 23 commits May 26, 2021 10:09

Shows event filters card on fleet page

f6934d2

Uses aggs instead of while loop to retrieve summary data

3864d72

Add request and response types in the lists package

64e9d65

Fixes old import

06a8f0c

Merge branch 'master' into feature/olm-add_event_filters_summary_card…

41c0bd7

…_to_the_fleet_endpoint_tab-1157

Removes old i18n keys

0ad0902

Removes more old i18n keys

662c59b

Use consts for exception lists url and endpoint event filter list id

aca55cd

Uses event filters service to retrieve summary data

84d46a4

Fixes addressed pr comments such as changing the route without unders…

e42bf61

…core, adding aggs type, validating response, and more

Uses useMemo instead of useState to memoize object

9f6b620

Add new e2e test for summart endpoint

5b17fd5

Handle api errors on event filters and trusted apps summary api calls

39c8133

Add api error message to the toast

b0d77b2

Fix wrong i18n key

9324dc3

Change span tag by react fragment

0cc6766

Uses styled components instead of modify compontent style directly an…

29014e8

…d small improvements on test -> ts

Adds curls script for summary route

8993d4e

Merge branch 'master' into feature/olm-add_event_filters_summary_card…

31538c7

…_to_the_fleet_endpoint_tab-1157

Adds new unit tests for fleet card components

bed96f6

Fixes some warnings on ui

940457d

Merge branch 'feature/olm-add_event_filters_summary_card_to_the_fleet…

9086f2f

…_endpoint_tab-1157' of github.com:dasansol92/kibana into feature/olm-add_event_filters_summary_card_to_the_fleet_endpoint_tab-1157

Merge branch 'master' into feature/olm-add_event_filters_summary_card…

eaae47d

…_to_the_fleet_endpoint_tab-1157

dasansol92 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 1, 2021

dasansol92 marked this pull request as ready for review June 1, 2021 10:02

dasansol92 requested a review from a team as a code owner June 1, 2021 10:02

academo approved these changes Jun 1, 2021

View reviewed changes

ashokaditya approved these changes Jun 1, 2021

View reviewed changes

Adds some syntax and readibility nits comming from pr comments

a13e57e

dasansol92 merged commit bdd7f7e into elastic:master Jun 2, 2021

dasansol92 mentioned this pull request Jun 2, 2021

[7.x] [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (#101034) #101151

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards #101034

[Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards #101034

dasansol92 commented Jun 1, 2021

elasticmachine commented Jun 1, 2021

academo Jun 1, 2021

dasansol92 Jun 1, 2021

academo Jun 1, 2021

dasansol92 Jun 1, 2021

ashokaditya left a comment

ashokaditya Jun 1, 2021

dasansol92 Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

ashokaditya Jun 1, 2021

kibanamachine commented Jun 1, 2021

References to deprecated APIs

[Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards #101034

[Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards #101034

Conversation

dasansol92 commented Jun 1, 2021

Summary

Checklist

For maintainers

elasticmachine commented Jun 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashokaditya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Jun 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

References to deprecated APIs

History