[TEST] Replace _source.mode with index.mapping.source.mode in integration tests #115926
Conversation
kkrik-es
added
>test
| - match: { test_standard_index_mode.mappings._source.mode: stored } | ||
|
|
||
| --- | ||
| create an index with time_series index mode and synthetic source: |
There was a problem hiding this comment.
These tests are now repeated above, since there's only one way to configure source mode.
| @@ -609,239 +344,3 @@ modify final setting after index creation: | |||
| body: | |||
| index: | |||
| mapping.source.mode: synthetic | |||
|
|
|||
| --- | |||
| modify source mapping from stored to disabled after index creation: | |||
There was a problem hiding this comment.
These tests are redundant, there's no way to configure source mode in mapping and updating the setting is covered in the test right above.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
LGTM |
| @@ -145,28 +145,6 @@ | |||
| - is_false: test_index.mappings.properties.foo.meta.bar | |||
| - match: { test_index.mappings.properties.foo.meta.baz: "quux" } | |||
|
|
|||
| --- | |||
| "disabling synthetic source fails": | |||
There was a problem hiding this comment.
maybe replace with a test that tries to update the new index setting?
There was a problem hiding this comment.
This is indices.put_mapping test :) we have this elsewhere..
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…tion tests (elastic#115926) * Replace _source.mode with index.mapping.source.mode in integration tests * fix tests * revert 40_source_mode_setting.yml (cherry picked from commit a360757)
…tion tests (elastic#115926) * Replace _source.mode with index.mapping.source.mode in integration tests * fix tests * revert 40_source_mode_setting.yml
source.modewill soon be deprecated, in favor of the corresponding index setting.Fixes #115860