Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Replace _source.mode with index.mapping.source.mode in integration tests - take 2 #116072

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Nov 1, 2024

Retrying #115926, this time with feature guarding to avoid failures in mixed cluster tests.

Related to #115860

@kkrik-es kkrik-es added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v8.17.0 labels Nov 1, 2024
@kkrik-es kkrik-es self-assigned this Nov 1, 2024
@kkrik-es kkrik-es marked this pull request as ready for review November 1, 2024 13:34
@kkrik-es kkrik-es requested a review from a team as a code owner November 1, 2024 13:34
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@kkrik-es
Copy link
Contributor Author

kkrik-es commented Nov 1, 2024

#116078 will help with the esql mixed cluster failures.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrik-es kkrik-es merged commit 4573ab8 into elastic:main Nov 4, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 116072

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Nov 4, 2024
…tion tests - take 2 (elastic#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (elastic#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded

(cherry picked from commit 4573ab8)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
@kkrik-es
Copy link
Contributor Author

kkrik-es commented Nov 4, 2024

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2024
…ntegration tests - take 2 (#116072) (#116161)

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests - take 2 (#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded

(cherry picked from commit 4573ab8)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java

* Update MapperFeatures.java
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
…tion tests - take 2 (elastic#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (elastic#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants