Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[TEST] Replace _source.mode with index.mapping.source.mode in integration tests" #116069

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Nov 1, 2024

Reverts #115926

The backport pr shows mixedClusterTest failures, it's better to rollback now and roll fwd with feature guarding.

@kkrik-es kkrik-es added >test Issues or PRs that are addressing/adding tests Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings labels Nov 1, 2024
@kkrik-es kkrik-es self-assigned this Nov 1, 2024
@kkrik-es kkrik-es marked this pull request as ready for review November 1, 2024 08:52
@kkrik-es kkrik-es requested a review from a team as a code owner November 1, 2024 08:52
@kkrik-es kkrik-es merged commit e8bf344 into main Nov 1, 2024
4 of 17 checks passed
@kkrik-es kkrik-es deleted the revert-115926-fix/115860 branch November 1, 2024 08:53
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Nov 1, 2024
kkrik-es added a commit that referenced this pull request Nov 4, 2024
…tion tests - take 2 (#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Nov 4, 2024
…tion tests - take 2 (elastic#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (elastic#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded

(cherry picked from commit 4573ab8)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2024
…ntegration tests - take 2 (#116072) (#116161)

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests - take 2 (#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded

(cherry picked from commit 4573ab8)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java

* Update MapperFeatures.java
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
…tion tests - take 2 (elastic#116072)

* Reapply "[TEST] Replace _source.mode with index.mapping.source.mode in integra…" (elastic#116069)

This reverts commit e8bf344.

* [TEST] Replace _source.mode with index.mapping.source.mode in integration tests

* add reason

* add reason

* spotless

* revert unneeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants