Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the usage of the _source.mode mapping attribute from rest integration tests. #115860

Closed
martijnvg opened this issue Oct 29, 2024 · 2 comments · Fixed by #115926
Closed

Remove the usage of the _source.mode mapping attribute from rest integration tests. #115860

martijnvg opened this issue Oct 29, 2024 · 2 comments · Fixed by #115926
Assignees
@kkrik-es
Labels
:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests

Comments

@martijnvg
Copy link
Member

martijnvg commented Oct 29, 2024 •
edited
Loading

The index.mapping.source.mode index setting should be used instead.
@martijnvg martijnvg added :StorageEngine/Mapping The storage related side of mappings >test Issues or PRs that are addressing/adding tests labels Oct 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@kkrik-es kkrik-es mentioned this issue Oct 30, 2024
Merged
@kkrik-es
Copy link
Contributor

kkrik-es commented Nov 1, 2024

Since it's not clear when we'll remove _source.mode entirely, I'm keeping references in x-pack/plugin/logsdb/src/yamlRestTest/resources/rest-api-spec/test/40_source_mode_setting.yml to make sure we have testing coverage for it, in combination with index.mapping.source.mode index setting.

@kkrik-es kkrik-es mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkrik-es kkrik-es

Labels
:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
3 participants
@martijnvg @elasticsearchmachine @kkrik-es