Check index setting for source mode in SourceOnlySnapshotRepository #116002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>non-issue
auto-backport
|
Test failure is unrelated, #116005 |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
This reverts commit 9bbf049.
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Oct 31, 2024
…lastic#116002) * Check index setting for source mode in SourceOnlySnapshotRepository * update * Revert "update" This reverts commit 9bbf049. (cherry picked from commit 37a4ee3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 31, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…lastic#116002) * Check index setting for source mode in SourceOnlySnapshotRepository * update * Revert "update" This reverts commit 9bbf049.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceOnlySnapshotRepositoryhas checks for incomplete source that use the document mapper. This is only populated when indexing docs, so earlier checks need to check the index setting for source mode to detect if the source will (eventually) be incomplete.This was detected as part of switching integration tests to use the index setting instead of the source mapper for configuring source mode, #115926,