Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCode Integration] Provide keybinding for export-svg command #415

Closed
tortmayr opened this issue Oct 9, 2021 · 0 comments · Fixed by eclipse-glsp/glsp-vscode-integration#41
Assignees
Labels

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Oct 9, 2021

Follow-up for #202
Provide the missing keybinding for the export-svg action

@tortmayr tortmayr added the vscode label Oct 9, 2021
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 23, 2023
## GLSP-894: Dispose client session on diagram close
Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before)
Fixes eclipse-glsp/glsp#894

## GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change  the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`.
Fixes eclipse-glsp/glsp#920

## GLSP-415 Provide keybinding for exportAsSvg Command
Fixes eclipse-glsp/glsp#415

## Remove extended doc from vscode-integration README
Remove the extended  `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of
interface & type info which has not been maintained and is rather outdated.  Since the creation of this README our documentation efforts
have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories.
They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 24, 2023
## GLSP-894: Dispose client session on diagram closes
Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before)
Fixes eclipse-glsp/glsp#894

## GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change  the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`.
Fixes eclipse-glsp/glsp#920

## GLSP-415 Provide keybinding for exportAsSvg Command
Fixes eclipse-glsp/glsp#415

## Remove extended doc from vscode-integration README
Remove the extended  `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of
interface & type info which has not been maintained and is rather outdated.  Since the creation of this README our documentation efforts
have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories.
They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
@tortmayr tortmayr self-assigned this May 27, 2023
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 30, 2023
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant