Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glspVscodeConnector doesn't give deselected items info #920

Closed
tortmayr opened this issue Feb 14, 2023 Discussed in #915 · 0 comments
Closed

glspVscodeConnector doesn't give deselected items info #920

tortmayr opened this issue Feb 14, 2023 Discussed in #915 · 0 comments
Assignees
@tortmayr
Labels
bug Something isn't working help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature vscode
Milestone
2.0.0 Release (Op...

Comments

@tortmayr
Copy link
Contributor

Discussed in #915

Originally posted by badrinarayan-R83 February 10, 2023
glspVscodeConnector.onSelectionUpdate gives an empty array if an element is deselected but provides no other info of the deselected item. Is there anyway to get list of deslected ids ?
@tortmayr tortmayr added bug Something isn't working vscode labels Feb 14, 2023
@tortmayr tortmayr added this to the 2.0.0 Release (Optional) milestone Feb 14, 2023
@planger planger added help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature labels Feb 23, 2023
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 23, 2023
@tortmayr
Bugfixes & documentation updates
bff720e 
## GLSP-894: Dispose client session on diagram close
Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before)
Fixes eclipse-glsp/glsp#894

## GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change  the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`.
Fixes eclipse-glsp/glsp#920

## Remove extended doc from vscode-integration README
Remove the extended  `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of
interface & type info which has not been maintained and is rather outdated.  Since the creation of this README our documentation efforts
have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories.
They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 23, 2023
@tortmayr
Bugfixes & documentation updates
e41ff93 
## GLSP-894: Dispose client session on diagram close
Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before)
Fixes eclipse-glsp/glsp#894

## GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change  the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`.
Fixes eclipse-glsp/glsp#920

## GLSP-415 Provide keybinding for exportAsSvg Command
Fixes eclipse-glsp/glsp#415

## Remove extended doc from vscode-integration README
Remove the extended  `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of
interface & type info which has not been maintained and is rather outdated.  Since the creation of this README our documentation efforts
have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories.
They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 24, 2023
@tortmayr
Bugfixes & documentation updates
343474a 
## GLSP-894: Dispose client session on diagram closes
Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before)
Fixes eclipse-glsp/glsp#894

## GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change  the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`.
Fixes eclipse-glsp/glsp#920

## GLSP-415 Provide keybinding for exportAsSvg Command
Fixes eclipse-glsp/glsp#415

## Remove extended doc from vscode-integration README
Remove the extended  `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of
interface & type info which has not been maintained and is rather outdated.  Since the creation of this README our documentation efforts
have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories.
They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
@tortmayr tortmayr mentioned this issue May 24, 2023
Closed
@tortmayr tortmayr self-assigned this May 27, 2023
@tortmayr tortmayr reopened this May 28, 2023
@planger planger closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
bug Something isn't working help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature vscode
Projects
None yet
Milestone
2.0.0 Release (Optional)
Development

Successfully merging a pull request may close this issue.

Bugfixes & documentation updates eclipse-glsp/glsp-vscode-integration
2 participants
@planger @tortmayr