Bugfixes & documentation updates #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## GLSP-894: Dispose client session on diagram closes Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before) Fixes eclipse-glsp/glsp#894 ## GLSP-920: Also provide deselection info in VSCode selector (breaking) Change the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`. Fixes eclipse-glsp/glsp#920 ## GLSP-415 Provide keybinding for exportAsSvg Command Fixes eclipse-glsp/glsp#415 ## Remove extended doc from vscode-integration README Remove the extended `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of interface & type info which has not been maintained and is rather outdated. Since the creation of this README our documentation efforts have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories. They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSP-894: Dispose client session on diagram closes
Refactor the
panelOnDisposeListenerof the vscode connector to also send adisposeClientSessionrequest (if the session has been successfully initialized before)Fixes eclipse-glsp/glsp#894
GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change the
onSelectionUpdateEvent of theglsp-vscode-connectorto provide both theselectedElementIds&deselectedElementids.Fixes eclipse-glsp/glsp#920
GLSP-415 Provide keybinding for exportAsSvg Command
Fixes eclipse-glsp/glsp#415
Remove extended doc from vscode-integration README
Remove the extended
Getting starteddocumentation part of the ´vscode-integration` README. This part contains a lot of interface & type info which has not been maintained and is rather outdated. Since the creation of this README our documentation efforts have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories. They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.