Skip to content

Commit

Permalink
Bugfixes & documentation updates
Browse files Browse the repository at this point in the history
## GLSP-894: Dispose client session on diagram closes
Refactor the `panelOnDisposeListener` of the vscode connector to also send a `disposeClientSession` request (if the session has been successfully initialized before)
Fixes eclipse-glsp/glsp#894

## GLSP-920: Also provide deselection info in VSCode selector (breaking)
Change  the `onSelectionUpdate` Event of the `glsp-vscode-connector` to provide both the `selectedElementIds` & `deselectedElementids`.
Fixes eclipse-glsp/glsp#920

## GLSP-415 Provide keybinding for exportAsSvg Command
Fixes eclipse-glsp/glsp#415

## Remove extended doc from vscode-integration README
Remove the extended  `Getting started` documentation part of the ´vscode-integration` README. This part contains a lot of
interface & type info which has not been maintained and is rather outdated.  Since the creation of this README our documentation efforts
have been shifted to the official GLSP Website and in general we try to avoid in-depth documentation in sub READMES of component repositories.
They are hard to maintain and will become outdated anyways. We try to use the website as "single source of truth" for documentation.
  • Loading branch information
tortmayr committed May 24, 2023
1 parent 4ae93b6 commit 343474a
Show file tree
Hide file tree
Showing 6 changed files with 72 additions and 587 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- [launch] Socket-based launch quickstart components now support auto-assigned ports [#33](https://github.com/eclipse-glsp/glsp-vscode-integration/pull/33)
- [launch ] Provide `NodeGlspVscodeServer` to enable direct server integration in the extension context without a dedicated server process [#37](https://github.com/eclipse-glsp/glsp-vscode-integration/pull/37)
- [diagram] Fixed a bug that prevented proper server-side disposal of diagram sessions [#40](https://github.com/eclipse-glsp/glsp-vscode-integration/pull/40)

### Breaking Changes

Expand All @@ -15,6 +16,8 @@
- Renamed `GlspServerLauncher` -> `GLSPSocketServerLauncher`
- Replaced `serverPort` property of `SocketGlspVscodeServerOptions` with `connectionOptions`
- Added `start()` and `onReady` to `GlspVscodeServer` interface
- [API] Refactored `GlspVscodeConnector.onSelectionUpdate` event [#40](https://github.com/eclipse-glsp/glsp-vscode-integration/pull/40)
- `Event<string[]>` -> `Event<{selectedElementIDs:string[], deselectedElementIDs:[]}>`

## [v1.0.0 - 30/06/2022](https://github.com/eclipse-glsp/glsp-client/releases/tag/v1.0.0)

Expand Down
8 changes: 7 additions & 1 deletion example/workflow/extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@
"command": "workflow.layout",
"when": "activeCustomEditorId == 'workflow.glspDiagram'"
},
{
"key": "alt+e",
"mac": "alt+e",
"command": "workflow.exportAsSVG",
"when": "activeCustomEditorId == 'workflow.glspDiagram'"
},
{
"key": "Ctrl+4",
"mac": "cmd+4",
Expand Down Expand Up @@ -197,8 +203,8 @@
"devDependencies": {
"@eclipse-glsp-examples/workflow-server": "next",
"@eclipse-glsp/vscode-integration": "1.1.0-next",
"@vscode/codicons": "^0.0.25",
"@types/vscode": "^1.54.0",
"@vscode/codicons": "^0.0.25",
"path": "^0.12.7",
"reflect-metadata": "^0.1.13",
"ts-loader": "^6.2.1",
Expand Down
1 change: 1 addition & 0 deletions packages/vscode-integration-webview/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This package helps you to implement a [VS Code Webview](https://code.visualstudi
In addition to this repository, the related source code can be found here:

- <https://github.com/eclipse-glsp/glsp-server>
- <https://github.com/eclipse-glsp/glsp-server-node>
- <https://github.com/eclipse-glsp/glsp-client>

## More information
Expand Down
Loading

0 comments on commit 343474a

Please sign in to comment.