Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for exporting SVG #202

Closed
tortmayr opened this issue Mar 24, 2021 · 2 comments
Closed

Implement support for exporting SVG #202

tortmayr opened this issue Mar 24, 2021 · 2 comments
Labels
enhancement New feature or request vscode

Comments

@tortmayr
Copy link
Contributor

Add a command + key binding to trigger the svg export. Potentially also add it to the vscode counterpart of the "diagram menu" (#201 )

@tortmayr tortmayr added bug Something isn't working vscode labels Mar 24, 2021
@tortmayr tortmayr added enhancement New feature or request and removed bug Something isn't working labels Mar 24, 2021
@lforst
Copy link

lforst commented Oct 7, 2021

PR eclipse-glsp/glsp-vscode-integration#15 adds the possibility to export a diagram as SVG using a menu contribution. However, a key binding for this functionality has not been added yet.

I would still recommend to consider this issue as resolved, because adding a keybinding for a command is a basic procedure using the VS Code API. All the components necessary to register such key bindings have already been implemented in the PR above.

@tortmayr
Copy link
Contributor Author

tortmayr commented Oct 9, 2021

Closing this issue. A follow-up issue for the missing keybinidng has been created

@tortmayr tortmayr closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode
Projects
None yet
Development

No branches or pull requests

2 participants