-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #2514 main_v11.0 clang #2556
Merged
JohnHalleyGotway
merged 1 commit into
dtcenter:main_v11.0
from
srherbener:feature/compile_mac_clang14.x
Jun 12, 2023
Merged
Bugfix #2514 main_v11.0 clang #2556
JohnHalleyGotway
merged 1 commit into
dtcenter:main_v11.0
from
srherbener:feature/compile_mac_clang14.x
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
JohnHalleyGotway
changed the title
Patches to allow compile using Mac Clang 14.x to complete
Bugfix #2514 main_v11.0 Clang
Jun 9, 2023
15 tasks
JohnHalleyGotway
changed the title
Bugfix #2514 main_v11.0 Clang
Bugfix #2514 main_v11.0 clang
Jun 9, 2023
PR #2563 with these same changes ran fine for the develop branch. GHA failed for this PR with the following error message:
But this is a short-coming of GHA for a PR from a fork rather than the actual code changes themselves. Proceeding with merging these changes. |
@JohnHalleyGotway thanks for merging this! What release should I expect to contain this fix? |
15 tasks
JohnHalleyGotway
pushed a commit
that referenced
this pull request
Sep 11, 2023
Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: Stephen Herbener <[email protected]> fix #2389 main_v11.0 flowchart (#2391) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405) fix #2380 main_v11.0 override (#2381) fix #2408 main_v11.0 empty config (#2409) fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403) fix #2415 main_v11.0 modulefiles (#2416) fix #2412 main_v11.0 climo (#2420) fix #2426 main_v11.0 buoy (#2432) fix #2437 main_v11.0 convert (#2438) fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix 2428 python from env main v11.0 (#2443) fix 2428 python csv input (#2450) fix #2452 main_v11.0 airnow (#2453) fix #2402 main_v11.0 sonarqube (First PR) (#2447) fix #2449 main_v11.0 pdf (#2465) fix 2428 python csv input (#2467) fix #2514 main_v11.0 clang (#2556) fix #2575 main_v11.0 python_convert (#2577) fix 2596 main v11.0 rpath compilation (#2600) fix 2596 main v11.0 rpath compilation (#2613) fix #2644 main_v11.0 percentile (#2645)
JohnHalleyGotway
added a commit
that referenced
this pull request
Dec 18, 2023
…2770) Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: Stephen Herbener <[email protected]> fix #2389 main_v11.0 flowchart (#2391) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405) fix #2380 main_v11.0 override (#2381) fix #2408 main_v11.0 empty config (#2409) fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403) fix #2415 main_v11.0 modulefiles (#2416) fix #2412 main_v11.0 climo (#2420) fix #2426 main_v11.0 buoy (#2432) fix #2437 main_v11.0 convert (#2438) fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix 2428 python from env main v11.0 (#2443) fix 2428 python csv input (#2450) fix #2452 main_v11.0 airnow (#2453) fix #2402 main_v11.0 sonarqube (First PR) (#2447) fix #2449 main_v11.0 pdf (#2465) fix 2428 python csv input (#2467) fix #2514 main_v11.0 clang (#2556) fix #2575 main_v11.0 python_convert (#2577) fix 2596 main v11.0 rpath compilation (#2600) fix 2596 main v11.0 rpath compilation (#2613) fix #2644 main_v11.0 percentile (#2645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches to allow compile using Mac Clang 14.x to complete
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [ No]
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [ No]
Pull Request Testing
Describe testing already performed for these changes: I manually tested these changes on my M1 Mac (Ventura13.4, Clang 14.0.3, GNU Fortran 12.2.0) and was able to successfully build Met11.0.2.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: There are no functional changes due to this PR. Unit testing via github should provide good coverage. Any additional testing that the reviewers deem worthwhile would be great.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] It seems due to the nature of these changes that documentation updates are not needed, but I'm completely open to including suggested documentation updates from reviewers.
Do these changes include sufficient testing updates? [Yes] It seems that test updates are not necessary since this PR does not modify any existing features. Again I'm open to including test updates suggested by reviewers.
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by [6/13/23]. I have no idea what is reasonable for setting a deadline for reviews to be complete since I'm not familiar with your workload. This is not urgent (because we have a workaround in spack-stack using the same patches) but would be good to get in soon. Please feel free to change this to a reasonable deadline given this information
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
Fixes #2514