Feature #2566 v11.1.0-rc1

[JohnHalleyGotway]

Expected Differences

Adds release notes for the 11.1.0-rc1 release. Also adds logic to replace '/' with '_' in the Docker tag names used by GHA. This logic was needed for the recent PR #2556 from a fork with a branch named feature/compile_mac_clang14.x. The '/' character is not allowed in Docker tag names.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Confirmed that GHA successfully compiles with the code even with the script changes.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Please review release notes here

I listed the date as tomorrow (20230614) since it's not getting done today.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [20230614].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[georgemccabe]

The compilation step fails because it is setting the DockerHub tag to the string get_dockerhub_tag.

The push refers to repository [docker.io/library/get_dockerhub_tag]

I made suggested changes that I think should fix it. I tested them in a bash shell locally.

[JohnHalleyGotway]

Thanks for catching these issues. Sorry, don’t know how I missed this. I could’ve sworn that it complied fine via GHA but perhaps I just saw the successful documentation workflow run? I’ll get this patched up tomorrow and merge after a successful compilation.

[JohnHalleyGotway]

Re-requesting review. The GHA run compiled fine. It does flag diffs but those are related to recently approved PR's and not this one.

[georgemccabe]

The compilation step is now working properly.
I reviewed the release notes and they look good. All items are descriptive and clear. The links are all correct as well.
I approve.