Skip to content

Commit

Permalink
Per #2566, use the POSIX compatible instead of backtick ci-skip-all
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnHalleyGotway committed Jun 14, 2023
1 parent 7bd0156 commit ad74887
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/jobs/build_docker_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source ${GITHUB_WORKSPACE}/.github/jobs/bash_functions.sh

DOCKERHUB_TAG=`get_dockerhub_tag`
DOCKERHUB_TAG=$(get_dockerhub_tag)

DOCKERFILE_PATH=${GITHUB_WORKSPACE}/internal/scripts/docker/Dockerfile.copy

Expand Down
2 changes: 1 addition & 1 deletion .github/jobs/push_docker_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source ${GITHUB_WORKSPACE}/.github/jobs/bash_functions.sh

DOCKERHUB_TAG=`get_dockerhub_tag`
DOCKERHUB_TAG=$(get_dockerhub_tag)

# skip docker push if credentials are not set
if [ -z ${DOCKER_USERNAME+x} ] || [ -z ${DOCKER_PASSWORD+x} ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/jobs/run_diff_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source ${GITHUB_WORKSPACE}/.github/jobs/bash_functions.sh

DOCKERHUB_TAG=`get_dockerhub_tag`
DOCKERHUB_TAG=$(get_dockerhub_tag)

# Get truth output data
${GITHUB_WORKSPACE}/.github/jobs/get_test_truth_data.sh ${TRUTH_DATA_VERSION}
Expand Down
2 changes: 1 addition & 1 deletion .github/jobs/run_unit_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source ${GITHUB_WORKSPACE}/.github/jobs/bash_functions.sh

DOCKERHUB_TAG=`get_dockerhub_tag`
DOCKERHUB_TAG=$(get_dockerhub_tag)

# Pull MET Image from DockerHub
${GITHUB_WORKSPACE}/.github/jobs/pull_docker_image.sh ${DOCKERHUB_TAG}
Expand Down
3 changes: 3 additions & 0 deletions .github/jobs/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
function myfunc() {

This comment has been minimized.

Copy link
@georgemccabe

georgemccabe Jun 14, 2023

Collaborator

It looks like this was checked in accidentally?

echo "hello world" | sed 's/o/0/g'
}

0 comments on commit ad74887

Please sign in to comment.