Feature #2677 v11.0.3

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Reviewed the 11.0.3 release notes.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

  • Please review these 11.0.3 release notes.
  • Please advise on the Note I added about this being the last planned bugfix release for 11.0.
  • Changing the version number from 11.0.2 to 11.0.3 causes the diff step to slow down considerably. In particular, differences will be flagged in all the MTD output and SEEPS/SEEPS_MPR line types. GHA ran the night of 9/7 but failed due the volume of differences.
  • On 9/8, I manually kicked off a regression test run on seneca:

cd /d1/personal/johnhg/MET/v11.0.3
MET/internal/scripts/regression/test_regression.sh main_v11.0-ref feature_2667_v11.0.3 >& test_regression_main_v11.0-ref_vs_feature_2667_v11.0.3.log

I expect that run will be more successful in identifying diffs.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fri 9/8/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

Note that the GHA logic for this PR failed. While all the unit tests ran without error, the diff step never completed during to the large volume of diffs and insufficient differencing logic.

In place of this I manually ran a regression test on seneca for this PR:

cd /d1/personal/johnhg/MET/v11.0.3
MET/internal/scripts/regression/test_regression.sh main_v11.0-ref feature_2677_v11.0.3 >& test_regression_main_v11.0-ref_vs_feature_2677_v11.0.3.log&

All of the unit tests also ran there without error and the diffs are described below.

• Differences are flagged in 14 files:

egrep -i "file1:|warning|error" test_regression_main_v11.0-ref_vs_feature_2677_v11.0.3.log | egrep -B 1 -i "warning|error" | grep file1

file1: MET-main_v11.0-ref/test_output/grid_stat/grid_stat_SEEPS_000000L_20211202_000000V_seeps.txt
file1: MET-main_v11.0-ref/test_output/grid_stat/grid_stat_SEEPS_000000L_20211202_000000V.stat
file1: MET-main_v11.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_2d.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_pair_cluster.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_pair_simple.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_single_cluster.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_single_simple.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_2d.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_pair_cluster.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_pair_simple.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_single_cluster.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_single_simple.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_SINGLE_20100517_010000V_2d.txt
file1: MET-main_v11.0-ref/test_output/mtd/mtd_SINGLE_20100517_010000V_3d_single_simple.txt

As expected, the diffs are confided to MTD and SEEPS output files. That's because the diff logic in main_v11.0 is insufficient for handling version diffs in those file types.

Spot-checking a couple of them, I can confirm the only real diffs are due to the version number changes from V11.0.2 to V11.0.3.

[jprestop]

Thank you for the information in this comment. It is helpful. I have reviewed the release notes, and they look good. I think that the note you added is perfect. Thanks for linking to the release support policy. I approve this request.