Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecations from persistence #333

Merged
merged 2 commits into from
Jan 4, 2020

Conversation

greg0ire
Copy link
Member

A backwards-compatibility layer has been added to persistence to help
consumers move to the new namespacing. It is based on class aliases,
which means the type declaration changes should not be a BC-break: types
are the same.
See doctrine/persistence#71

This means:

  • using the new namespaces
  • adding autoload calls for new types to types that may be extended and
    use persistence types in type declarations of non-constructor methods,
    so that signature compatibility is recognized by old versions of php.
    More details on this at
    https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf

A backwards-compatibility layer has been added to persistence to help
consumers move to the new namespacing. It is based on class aliases,
which means the type declaration changes should not be a BC-break: types
are the same.
See doctrine/persistence#71

This means:
- using the new namespaces
- adding autoload calls for new types to types that may be extended and
use persistence types in type declarations of non-constructor methods,
so that signature compatibility is recognized by old versions of php.
More details on this at
https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf
@greg0ire
Copy link
Member Author

Seems like this has to do with doctrine/orm#7079

We use SQLite in tests, and that platform does not support schemas.
@greg0ire greg0ire merged commit 89594f4 into doctrine:1.4.x Jan 4, 2020
@greg0ire greg0ire deleted the address-persistence-deprecations branch January 4, 2020 15:25
@greg0ire greg0ire added this to the 1.4.1 milestone Jan 13, 2020
@@ -139,3 +140,5 @@ public function purge()
*/
abstract public function execute(array $fixtures, $append = false);
}

interface_exists(ObjectManager::class);
Copy link

@shadowhand shadowhand Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line included? It appears a couple of other places too, and seems like debugging code left behind.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really isn't. If you want to know, follow the link in the PR body / the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants