Fix getJoinTableName for sqlite with schema attribute #7079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do add tests verifying your fix 👍 |
|
I was suffering this problem, and this PR solved my issues. Can I help to get this PR merged? |
greg0ire
reviewed
Nov 4, 2019
|
@ajgarlag I just added a new comment, so let's wait for OP to respond, and if there is no activity, you may open a new PR with these changes + my comment taken into account. |
A diagnosis regarding the build would help. It doesn't look related with this PR, but will have to be fixed. Maybe other PRs have the same issue? |
|
Ok so a simple rebase should fix things, right? |
greg0ire
previously approved these changes
Nov 6, 2019
|
I think this PR should be added to next milestone |
Join table name doesnt depending on the platform. Table name was "schema.table" instead of "schema__table". (cherry picked from commit 4878cd3)
lcobucci
approved these changes
Nov 18, 2019
lcobucci
changed the title
This was referenced Nov 25, 2019
vilartoni
added a commit
to Emagister/doctrine-orm
that referenced
this pull request
Jan 14, 2020
…gin-master v2.7.0 [](https://travis-ci.org/doctrine/orm) This release solves Symfony 5.0 compatibility issues, some small improvements, and adds various deprecation notices. Please read carefully the [upgrade to 2.7 notes](https://github.com/doctrine/orm/blob/2.7/UPGRADE.md#upgrade-to-27) to know more about the reasons and how to fix the deprecation messages. --- - Total issues resolved: **1** - Total pull requests resolved: **15** - Total contributors: **10** Deprecation ----------- - [7911: Be explicit about which Doctrine package in message](doctrine#7911) thanks to @lcobucci - [7909: Add deprecation messages](doctrine#7909) thanks to @lcobucci - [7901: Add deprecation warnings for 2.7.x](doctrine#7901) thanks to @lcobucci - [7701: Split and deprecate AbstractQuery#useResultCache()](doctrine#7701) thanks to @someniatko CI -- - [7904: Make sure composer files are valid](doctrine#7904) thanks to @greg0ire - [7600: &doctrine#91;2.7&doctrine#93; CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#7600) thanks to @Majkl578 Improvement ----------- - [7876: Fix compat of commands with Symfony 5](doctrine#7876) thanks to @nicolas-grekas - [7829: Skip Paginator LIMIT subquery and WHERE IN if query do not have LIMIT](doctrine#7829) thanks to @Seb33300 - [7723: Allow Symfony 5.0](doctrine#7723) thanks to @nicolas-grekas - [7710: Prettified arrays in tool command orm:mapping:describe](doctrine#7710) thanks to @rtek - [7340: Fix config template for PHPUnit >= 7.2](doctrine#7340) thanks to @guilliamxavier BC Break,Improvement -------------------- - [7863: Paginator: Skip limit subquery if not required](doctrine#7863) thanks to @Seb33300 Documentation ------------- - [7382: Update homepage](doctrine#7382) thanks to @Majkl578 Bug --- - [7326: Cherry-pick doctrine#7307 to fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common](doctrine#7326) thanks to @nicolas-grekas - [7079: Fix getJoinTableName for sqlite with schema attribute](doctrine#7079) thanks to @mairo744 BC Break,Deprecation,Improvement -------------------------------- - [6803: Deprecation of EntityManager copy method](doctrine#6803) thanks to @SenseException
](https://travis-ci.org/doctrine/orm){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect table name for join tables in sqlite db when it contains schema attribute.
getJoinTableNamedoesnt depending on the platform.Table name was "schema.table" instead of "schema__table".
Inspired by similar function
getTableName.