Fix build #303
Merged
Fix build #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 the 7.4 job fails, maybe it doesn't pull the same deps as the other jobs? EDIT: doesn't look like it from the output |
|
I now believe this has to do with the data-fixtures lib |
|
I made a PR to address this: doctrine/data-fixtures#333 |
|
Ok so now it's slightly better… but the version of the lib I'm requiring requires php 7.2… should I drop 7.1? |
A backwards-compatibility layer has been added to persistence to help consumers move to the new namespacing. It is based on class aliases, which means the type declaration changes should not be a BC-break: types are the same. See doctrine/persistence#71 This means: - using the new namespaces - adding autoload calls for new types to types that may be extended and use persistence types in type declarations of non-constructor methods, so that signature compatibility is recognized by old versions of php. Luckily, there are none of those in this bundle. This explicitely requires the persistence lib, which was an unworded dependency of this bundle. I think it was not added because it the depency was not noticed, but there might be more implicit dependencies (doctrine/common, doctrine/doctrine-bundle). Addressing the deprecations fixes the unit tests, because one of them was expecting the old namespace in an exception message.
It is recommended to do so.
To be reverted on master, where the deprecation can be addressed by upgrading doctrine/data-fixtures (the latest version require php ^7.2, which we cannot use on 3.3.x).
SenseException
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.