Doctrine\Common\Persistence\ObjectManager is deprecated #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use the new Doctrine\Persistence\ObjectManager because of TypeHinting.
|
There will be new releases for all affected projects to account for the deprecations. Thanks for bringing it up 👍 |
greg0ire
reviewed
Dec 14, 2019
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| namespace Doctrine\Common\DataFixtures; | |||
|
|
|||
| use Doctrine\Common\Persistence\ObjectManager; | |||
| use Doctrine\Common\Persistence\ObjectManager as DeprecatedManager; | |||
| use Doctrine\Persistence\ObjectManager; | |||
There was a problem hiding this comment.
These are not 2 different classes, one is actually an alias to the other one, so there is no issue with using the new name in the signature because it's the same thing
|
Fixed in #333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but you cant use the new Doctrine\Persistence\ObjectManager because of TypeHinting.
Found that on the FixtureBundle 3.3 in Symfony 5.