This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Add ItemList Class #175
Merged
Add ItemList Class #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves the following:
Growing to be a pretty big PR. Will need to test a bit before adding to the release. |
|
@msessa @tallpauley PTAL when you guys got a chance. I'm terrible with styles, btw, so please feel free to comment or make a PR to this branch if you guys are good with that. Otherwise we should see if anyone in the community wants to help out in that regard. |
|
There is a docker image available for testing @ |
|
Received feedback in the issues thread themselves, merging. |
conor-mullen
added a commit
to Financial-Times/vault-ui
that referenced
this pull request
Jan 31, 2018
* ENTRYPOINT with CUSTOM_CA_CERT env var * Replace HCL parsing library * Helm chart for vault-ui (djenriquez#149) * chart import * README added * added directory for better clarity * fix chart description * Upgrade base image to node:8.1.4-alpine (djenriquez#148) * Upgrade base image to node:8.1.4-alpine * fix invalid github endpoint var name * fix invalid github endpoint var name (djenriquez#155) * Upgrade base image to node:8.1.4-alpine * fix invalid github endpoint var name * Update Github.jsx * Okta Authentication Backend (djenriquez#156) * Add Okta resources * Remove comments * Add check for required org name * allows for server port to be configured via env var PORT (djenriquez#162) * Update PolicyPicker.jsx (djenriquez#169) * Add login button (djenriquez#172) * Add login button * Improve validation * AppRole Authentication Backend (djenriquez#171) * Initial commit for approle auth * Place role name field in new render * Add property fields + fix create/update * Complete base functionality * Update README.md * Fix README, clarify NODE_TLS_REJECT_UNAUTHORIZED * Fix typo (djenriquez#176) * Add ItemList Class (djenriquez#175) * Introduce ItemList obj * Upgrade base node image * Add ItemList to AWS, clean up * Add ItemList to AWSEc2, clean up * Fix deleteobject logic * Fix delete for AWS * Fix delete for awsec2 * Add max items per page option * Fix bug that randomly sets page * Bug fixes + itemlist progress * More bug fixes * Cleanup and rename policypicker to itempicker * Add ItemList to Radius * Add ItemList to UserPass * Refactor Secrets to use ItemList * Fix styling * Remove case insensitivity * Clean up directory separator * Fix delete regression * Cleanup itemUri * Breadcrumb Styles Improvement & "copy path" icon button (djenriquez#180) * improving breadcrumb styles, adding copy path button * improve spacing * fix dash issue w/ breadcrumb * Fix favicon (djenriquez#188) * Update README.md Add gitter badge * Add itemlist to policy management (djenriquez#187) * Update README.md * Update LICENSE * fixing behavior for ALL breaking characters * Upgrade node to 8.5, remove deprecated MAINTAINER (djenriquez#193) * clarifies expected value for VAULT_URL_DEFAULT (djenriquez#194) Adds a notice to the description of the VAULT_URL_DEFAULT parameter explaining that the protocol part of the url is mandatory. This is a workaround for the unclear error message an user gets if it is missing * Correct the dist reference for the electron app (djenriquez#199) * Add KV compatibility (djenriquez#198) * Maintenance: Upgrade packages (djenriquez#200) * Upgrade dependencies * Upgrade base node image * Add stop propogation fix for upgrade bug * Fix paging bug * Upgrade react, react-dom, pagination * Upgrade babel, webpack, extract-text-webpack-plugin; add prop-types in prep for React 16 * Update CHANGELOG * Update version * Squash big but easy bug for userpass (djenriquez#201) * v2.4.0-rc2 * Fix secrets list reset (djenriquez#202) * Fix navigation bug when access is denied (djenriquez#203) * Fix path navigation when access is denied * Cleanup fix * Improve Vault endpoint check (djenriquez#204) * empty catch statements don't resolve, breaking behavior if can't create orphan * Improve styling (djenriquez#207) * Improve real-estate * Fix z-index for content container * Fix scrolling (djenriquez#208) * Improve real-estate * Fix z-index for content container * Fix styling /w @Lucretius help * Fix right border with overflow enabled * Reduce right margin * v2.4.0-rc3 * Upgrade to node alpine-8.8 (djenriquez#218) * Add logic to handle supplied auth token header (djenriquez#220) * Fix policy schema (djenriquez#228) * Add new vault properties * Update policy schema * Remove nodemon from default run (djenriquez#227) * Updated yarn.lock after yarn build * Updated packagaes * Specify electron-builder version * Updated electron to resolve critical vulnerability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ItemList
This PR introduces the ItemList class. The ItemList class centralizes the management of lists used in Vault. Currently, lists used for Authentication Backend modules are managed separately and can lead to drift between each. This allows all lists to be managed under one class, giving pagination and filtering by default.
This should be pretty simple to push out to all modules except tokens, which currently use a very different list structure.
ItemPicker
Renamed
PolicyPickertoItemPickerand refactored for general improvements.Reference
#174
#173
#132